Skip to content

Try 1.5x as a vec growth factor #108718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

thomcc
Copy link
Member

@thomcc thomcc commented Mar 3, 2023

This is just for perf run

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@thomcc
Copy link
Member Author

thomcc commented Mar 3, 2023

@bors try @rust-timer queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 3, 2023
@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 3, 2023
@bors
Copy link
Collaborator

bors commented Mar 3, 2023

⌛ Trying commit 12557d4 with merge 914e8a1022e44f3484c3d593d99d6cc641dcbcde...

@thomcc
Copy link
Member Author

thomcc commented Mar 3, 2023

r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2023

Failed to set assignee to ghost: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@thomcc
Copy link
Member Author

thomcc commented Mar 3, 2023

I don't expect this to be a win (It wasn't locally, nor back in the day #4961), but who knows.

@workingjubilee workingjubilee removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2023
@thomcc
Copy link
Member Author

thomcc commented Mar 4, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Mar 4, 2023

⌛ Trying commit e8c2c43 with merge 8279faf6b4ecc64684aaa86e28e1f38ae822c55c...

@bors
Copy link
Collaborator

bors commented Mar 4, 2023

☀️ Try build successful - checks-actions
Build commit: 8279faf6b4ecc64684aaa86e28e1f38ae822c55c (8279faf6b4ecc64684aaa86e28e1f38ae822c55c)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8279faf6b4ecc64684aaa86e28e1f38ae822c55c): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.0% [0.2%, 16.8%] 165
Regressions ❌
(secondary)
1.0% [0.2%, 2.8%] 91
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.0% [0.2%, 16.8%] 165

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)
5.1% [1.4%, 12.3%] 11
Improvements ✅
(primary)
-1.6% [-4.3%, -0.9%] 51
Improvements ✅
(secondary)
-3.0% [-7.4%, -1.1%] 25
All ❌✅ (primary) -1.5% [-4.3%, 3.2%] 52

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [0.7%, 2.8%] 55
Regressions ❌
(secondary)
1.8% [1.0%, 3.0%] 15
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.3% [0.7%, 2.8%] 55

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 4, 2023
@thomcc
Copy link
Member Author

thomcc commented Mar 4, 2023

Seems bad!

@thomcc thomcc closed this Mar 4, 2023
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-14 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:ac593985615ec2ede58e132d2e21d2b1cbd6127c)
Download action repository 'rust-lang/simpleinfra@master' (SHA:0fdabd83e1d3faaa8e9cfd7c00031e3a92997344)
Complete job name: PR (x86_64-gnu-llvm-14, false, ubuntu-20.04-xl)
git config --global core.autocrlf false
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  CI_JOB_NAME: x86_64-gnu-llvm-14
---

---- [ui] tests/ui/hygiene/panic-location.rs stdout ----
diff of run.stderr:

- thread 'main' panicked at 'capacity overflow', library/alloc/src/raw_vec.rs:525:5
+ thread 'main' panicked at 'capacity overflow', library/alloc/src/raw_vec.rs:528:5
3 


The actual run.stderr differed from the expected run.stderr.
The actual run.stderr differed from the expected run.stderr.
Actual run.stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/hygiene/panic-location/panic-location.run.stderr
error: 1 errors occurred comparing run output.
status: exit status: 101
status: exit status: 101
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/hygiene/panic-location" && RUST_BACKTRACE="0" RUST_TEST_THREADS="16" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/hygiene/panic-location/a"
stdout: none
--- stderr -------------------------------
thread 'main' panicked at 'capacity overflow', library/alloc/src/raw_vec.rs:528:5
------------------------------------------



Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants