-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update host compiler to LLVM 16 #108802
Update host compiler to LLVM 16 #108802
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit ac7651a73bcd81d3f08af5885319d990ac847876 with merge 64c5e2fe193d64f285526bd0125c1799c7d54601... |
💔 Test failed - checks-actions |
Ah yes, another display of how much LLD values backwards compatibility. Looks like you can't even build LLVM 15 using LLD 16. |
Uff, and of course you can't even easily work around this by adding I'm inclined to just roll this change into the main LLVM 16 upgrade, even though I would have preferred a separate performance evaluation for this. |
Closing in favor of #107224. |
This comment has been minimized.
This comment has been minimized.
This updates the host compiler for dist-x86_64-linux to LLVM 16, pulling in the BOLT fix at llvm/llvm-project@1de305d, which is needed to update Rust to LLVM 16.
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit cbf1517 with merge 68f5536e18acf6022f362483c791ebbcac264894... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (68f5536e18acf6022f362483c791ebbcac264894): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
@rustbot ready Thanks to llvm/llvm-project#61208, LLD 16 is capable of building LLVM 15 again, so we can land this separately after all. |
@bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (2d0a7de): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Update the host compiler for dist-x86_64-linux to LLVM 16. In particular, this pulls in llvm/llvm-project@1de305d, which is needed to update Rust's own LLVM (#107224).