Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update host compiler to LLVM 16 #108802

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Update host compiler to LLVM 16 #108802

merged 1 commit into from
Mar 18, 2023

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Mar 6, 2023

Update the host compiler for dist-x86_64-linux to LLVM 16. In particular, this pulls in llvm/llvm-project@1de305d, which is needed to update Rust's own LLVM (#107224).

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 6, 2023
@nikic
Copy link
Contributor Author

nikic commented Mar 6, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2023
@bors
Copy link
Contributor

bors commented Mar 6, 2023

⌛ Trying commit ac7651a73bcd81d3f08af5885319d990ac847876 with merge 64c5e2fe193d64f285526bd0125c1799c7d54601...

@bors
Copy link
Contributor

bors commented Mar 6, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2023
@nikic
Copy link
Contributor Author

nikic commented Mar 6, 2023

Ah yes, another display of how much LLD values backwards compatibility. Looks like you can't even build LLVM 15 using LLD 16.

@nikic
Copy link
Contributor Author

nikic commented Mar 6, 2023

Uff, and of course you can't even easily work around this by adding -Wl,--undefined-version to LDFLAGS, because cmake will sanity-check the compiler early in the build, long before -fuse-ld=lld is added, so we end up passing --undefined-version to an old ld.bfd version, which does not support it.

I'm inclined to just roll this change into the main LLVM 16 upgrade, even though I would have preferred a separate performance evaluation for this.

@nikic
Copy link
Contributor Author

nikic commented Mar 6, 2023

Closing in favor of #107224.

@nikic nikic closed this Mar 6, 2023
@rust-log-analyzer

This comment has been minimized.

This updates the host compiler for dist-x86_64-linux to LLVM 16,
pulling in the BOLT fix at
llvm/llvm-project@1de305d,
which is needed to update Rust to LLVM 16.
@nikic
Copy link
Contributor Author

nikic commented Mar 11, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Mar 11, 2023

⌛ Trying commit cbf1517 with merge 68f5536e18acf6022f362483c791ebbcac264894...

@bors
Copy link
Contributor

bors commented Mar 11, 2023

☀️ Try build successful - checks-actions
Build commit: 68f5536e18acf6022f362483c791ebbcac264894 (68f5536e18acf6022f362483c791ebbcac264894)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (68f5536e18acf6022f362483c791ebbcac264894): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-1.0%, -0.3%] 34
Improvements ✅
(secondary)
-0.7% [-1.0%, -0.5%] 12
All ❌✅ (primary) -0.7% [-1.0%, -0.3%] 34

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.2% [-4.2%, -2.6%] 6
Improvements ✅
(secondary)
-2.4% [-4.1%, -0.7%] 55
All ❌✅ (primary) -3.2% [-4.2%, -2.6%] 6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.0% [-1.2%, -0.7%] 14
Improvements ✅
(secondary)
-0.9% [-0.9%, -0.8%] 2
All ❌✅ (primary) -1.0% [-1.2%, -0.7%] 14

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 11, 2023
@nikic
Copy link
Contributor Author

nikic commented Mar 11, 2023

@rustbot ready

Thanks to llvm/llvm-project#61208, LLD 16 is capable of building LLVM 15 again, so we can land this separately after all.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 11, 2023
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Mar 18, 2023

📌 Commit cbf1517 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023
@bors
Copy link
Contributor

bors commented Mar 18, 2023

⌛ Testing commit cbf1517 with merge 2d0a7de...

@bors
Copy link
Contributor

bors commented Mar 18, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 2d0a7de to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 18, 2023
@bors bors merged commit 2d0a7de into rust-lang:master Mar 18, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 18, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2d0a7de): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-1.4%, -0.3%] 38
Improvements ✅
(secondary)
-0.9% [-1.7%, -0.6%] 11
All ❌✅ (primary) -0.7% [-1.4%, -0.3%] 38

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)
2.0% [2.0%, 2.1%] 2
Improvements ✅
(primary)
-1.0% [-1.4%, -0.6%] 4
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.5% [-1.4%, 1.4%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.8% [-0.9%, -0.5%] 8
Improvements ✅
(secondary)
-1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) -0.8% [-0.9%, -0.5%] 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants