Implement IEEE 754 comparisons for floats (#1084) #1090
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than being defined as !positive and !negative, these should act the same as negative and positive (respectively). The only effect of this change should be that all four functions will now return false for NaN.
|
mbrubeck/rust@1f5e47e adds some more isNaN tests. |
This was referenced Oct 28, 2011
coastalwhite
pushed a commit
to coastalwhite/rust
that referenced
this pull request
Aug 5, 2023
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
* Audit for `ptr_guaranteed_<cmp>` * Update docs * Add two tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some important bugs in NaN comparisons (#1083). However, there are some well-known issues with IEEE 754 semantics that we might not want in Rust, so this might not be exactly what we want to do. See #1084 for discussion.
This also uncovered a bug in float::from_str that the tests did not catch before. I commented out the failing test and filed #1089 to fix it.
This is my first real patch to the self-hosted compiler, and I'm still figuring out how things work. Please don't hesitate to tell me if anything could be improved!