-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename config.toml.example
to config.example.toml
#109031
Conversation
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
Does t-bootstap do FCPs? It doesn't seem like it, but if they do this should possibly have a needs-fcp tag. |
This also makes tab completing a bit easier: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea. Can you also make a PR updating the dev guide?
I think we should merge this once the dev-guide PR is ready and open |
@rustbot blocked |
why is this blocked @ozkanonur |
Ok, I see it's rust-lang/rustc-dev-guide#1641 here. I didn't see it my bad. |
@bors r+ rollup |
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#108651 (Forbid the use of `#[target_feature]` on `main`) - rust-lang#109009 (rustdoc: use restricted Damerau-Levenshtein distance for search) - rust-lang#109026 (Introduce `Rc::into_inner`, as a parallel to `Arc::into_inner`) - rust-lang#109029 (Gate usages of `dyn*` and const closures in macros) - rust-lang#109031 (Rename `config.toml.example` to `config.example.toml`) - rust-lang#109032 (Use `TyCtxt::trait_solver_next` in some places) - rust-lang#109047 (typo) - rust-lang#109052 (Add eslint check for rustdoc-gui tester) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This had bothered me for a while as it leads to bad (missing) syntax highlighting in most editors I've used, and @jyn514 suggested I just make the change and that the compatibility concerns I had don't really matter.
I suspect it will be a contentious one, so will not be offended if the outcome of this is to close the PR.