-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add #[doc(alias="flatmap")]
to Option::and_then
#109093
Conversation
I keep forgetting that rust calls this `and_then` and trying to search for `flatmap`. `and_then`'s docs even mention "Some languages call this operation flatmap", but it doesn't show up as a result in the search at `https://doc.rust-lang.org/std/?search=flatmap`
(rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
The relevant section of the policy:
IMO that policy is too strict and this PR should be merged, but I think due to the policy, it means that this PR can't add Prior PRs like #81989 for example were rejected, but those were much larger in scope than this one so idk, maybe |
I think this follows the policy: it seems reasonable to me that someone might search for "flatmap" in the Rust documentation expecting to find it. @bors r+ rollup |
add `#[doc(alias="flatmap")]` to `Option::and_then` I keep forgetting that rust calls this `and_then` and trying to search for `flatmap`. `and_then`'s docs even mention "Some languages call this operation flatmap", but it doesn't show up as a result in the search at `https://doc.rust-lang.org/std/?search=flatmap`
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#109093 (add `#[doc(alias="flatmap")]` to `Option::and_then`) - rust-lang#110701 (Fix `x test core` when download-rustc is enabled) - rust-lang#111982 (Revert "Enable incremental independent of stage") - rust-lang#112158 (Add portable-simd mention) - rust-lang#112172 (doc: improve explanation) - rust-lang#112178 (Fix bug where private item with intermediate doc hidden re-export was not inlined) r? `@ghost` `@rustbot` modify labels: rollup
I keep forgetting that rust calls this
and_then
and trying to search forflatmap
.and_then
's docs even mention "Some languages call this operation flatmap", but it doesn't show up as a result in the search athttps://doc.rust-lang.org/std/?search=flatmap