-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix impl_trait_ty_to_ty substs for -Zlower-impl-trait-in-trait-to-assoc-ty #109244
Conversation
@rustbot author I'd like to check this out a bit better but feel free to leave thoughts. |
ed4eecc
to
593d6af
Compare
This comment has been minimized.
This comment has been minimized.
47991db
to
bebb98b
Compare
@rustbot review |
@compiler-errors I think this commit goes in the right direction but the error that I'm getting in
The code grabs the fn_def_id for both trait and impls but still |
@rustbot author found the problem,
Which is clearly wrong. Fixing it ... |
I think this can be merged because it's fixes a problem related to @rustbot review |
c42f2f1
to
10f4447
Compare
These commits modify the If this was intentional then you can ignore this comment. |
b23f2f1
to
8cde7f3
Compare
@compiler-errors this one should be ready too. |
8cde7f3
to
9139ed0
Compare
#109277 includes this and other stuff. |
impl_trait_ty_to_ty was assuming that all substs were about lifetimes and this is not true anymore with the new RPITITs synthesized as associated types.
The only relevant commit is bebb98b.
r? @compiler-errors