Remove the NodeId of ast::ExprKind::Async
#109354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
|
Hm, @bors seems to be stuck? |
|
@bors ping |
|
😪 I'm awake I'm awake |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2023
…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#109330 (rustdoc: Fix ICE for intra-doc link on intermediate re-export) - rust-lang#109354 (Remove the `NodeId` of `ast::ExprKind::Async`) - rust-lang#109445 (Allow passing the --nocapture flag to compiletest) - rust-lang#109512 (bump `askama_derive` to 0.12.1) - rust-lang#109637 (Add missing needs-asm-support annotation to ui/simple_global_asm.rs) - rust-lang#109666 (Correct ASCII case comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 6, 2023
…errors Remove the `NodeId` of `ast::ExprKind::Async` This is a followup to rust-lang#104833 (review). In my original attempt, I was using `LoweringContext::expr`, which was not correct as it creates a fresh `DefId`. It now uses the correct `DefId` for the wrapping `Expr`, and also makes forwarding `#[track_caller]` attributes more explicit.
calebcartwright
pushed a commit
to calebcartwright/rust
that referenced
this pull request
Jun 20, 2023
…errors Remove the `NodeId` of `ast::ExprKind::Async` This is a followup to rust-lang#104833 (review). In my original attempt, I was using `LoweringContext::expr`, which was not correct as it creates a fresh `DefId`. It now uses the correct `DefId` for the wrapping `Expr`, and also makes forwarding `#[track_caller]` attributes more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #104833 (review).
In my original attempt, I was using
LoweringContext::expr, which was not correct as it creates a freshDefId.It now uses the correct
DefIdfor the wrappingExpr, and also makes forwarding#[track_caller]attributes more explicit.