-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add #[inline] to as_deref #109357
Add #[inline] to as_deref #109357
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit d3352de with merge a8e55ffe1b355d32d0bd1312ca73e3c14a36b2a2... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (a8e55ffe1b355d32d0bd1312ca73e3c14a36b2a2): comparison URL. Overall result: ❌✅ regressions and improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
@bors r+ |
perf was mostly neutral and the queue is pretty filled up |
Add #[inline] to as_deref While working on rust-lang#109247 I found an `as_deref` call in the compiler that should have been inlined. This fixes the missing inlining (but doesn't address the perf issues I was chasing). r? `@thomcc`
⌛ Testing commit d3352de with merge c4bd06483e83dd098d08b87715bcbe280096d771... |
💔 Test failed - checks-actions |
@bors retry github incident |
⌛ Testing commit d3352de with merge 821abb7f68162676092a4855637f32bcd16b5390... |
💔 Test failed - checks-actions |
@bors p=111 (Let's see if a non-compiler change can get through) |
⌛ Testing commit d3352de with merge 836d3dc997cc36fda5d1d5e117c90cb1990fa4d2... |
@bors p=0 (resetting back to normal) |
💔 Test failed - checks-actions |
@bors rollup=never |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors p=111 (The queue's doing nothing right now, but some are getting through, so let's give this a shot) |
☀️ Test successful - checks-actions |
Finished benchmarking commit (db0cbc4): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
While working on #109247 I found an
as_deref
call in the compiler that should have been inlined. This fixes the missing inlining (but doesn't address the perf issues I was chasing).r? @thomcc