Introduce `AliasKind::Inherent` for inherent associated types #109410

fmease · 2023-03-20T19:04:56Z

Allows us to check (possibly generic) inherent associated types for well-formedness.
Type inference now also works properly.

Follow-up to #105961. Supersedes #108430.
Fixes #106722.
Fixes #108957.
Fixes #109768.
Fixes #109789.
Fixes #109790.

~~Not to be merged before #108860 (AliasKind::Weak).~~

CC @jackh726
r? @compiler-errors

@rustbot label T-types F-inherent_associated_types

rustbot · 2023-03-20T19:05:07Z

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

compiler-errors

first round of comments, need to think more about some things like wf and implied bounds

compiler/rustc_middle/src/ty/sty.rs

compiler/rustc_hir_analysis/src/coherence/orphan.rs

compiler/rustc_hir_analysis/src/collect/item_bounds.rs

compiler-errors · 2023-03-20T19:12:59Z

compiler/rustc_hir_analysis/src/collect/predicates_of.rs

@@ -395,6 +395,8 @@ pub(super) fn trait_explicit_predicates_and_bounds(
    gather_explicit_predicates_of(tcx, def_id.to_def_id())
 }

+// FIXME(fmease): Needs investigation: Do & can we need to handle inherent associated types more
+// ‘precisely’ here? E.g. to break cycles.


Would be nice to link to an issue or known-bug ui test that explains when we get cycles here.

compiler-errors · 2023-03-20T19:16:59Z

compiler/rustc_hir_analysis/src/outlives/implicit_infer.rs

@@ -196,6 +196,7 @@ fn insert_required_predicates_to_be_wf<'tcx>(
                }
            }

+            // FIXME(fmease): Do we need to handle inherent projections similarly here?


Probably? it would be nice to create a test exercising this behavior... maybe something like:

struct Foo; impl Foo { type IAT<'a, T> = &'a T; } struct Bar<'a, T>(Foo::IAT<'a, T>);

Unless I'm getting this mixed up with other implicit outlives code 🙃

Right now I have a negative behavior test for type IAT<'a, T> = &'a T; (i.e. no implied bounds).

compiler/rustc_trait_selection/src/traits/project.rs

src/librustdoc/clean/mod.rs

…-in-self-ty, r=compiler-errors Use region-erased self type during IAT selection Split off from rust-lang#109410 as discussed. Fixes rust-lang#109299. Re UI test: I use a reproducer of rust-lang#109299 that contains a name resolution error instead of reproducer [`regionck-2.rs`](https://github.com/rust-lang/rust/blob/fc7ed4af165c27ab5914b93251194f826920cc65/tests/ui/associated-inherent-types/regionck-2.rs) (as found in the `AliasKind::Inherent` PR) since it would (incorrectly) pass typeck in this PR due to the lack of regionck and I'd rather not make *that* a regression test (with or without `known-bug`). `@rustbot` label F-inherent_associated_types r? `@compiler-errors`

compiler-errors · 2023-03-22T05:13:42Z

Noting so I don't forget -- @fmease can you change these FIXME(fmease) to FIXME(inherent-associated-types)? It's best to be able to search feature-related FIXMEs by their gate name, so that they can, for example, be revisited during stabilization, or if someone just wants to explore what still needs to be answered for IATs.

Of course, the ones that are really notes-to-self are fine, but ones that are follow-ups for the actual feature itself could be changed. I didn't look too hard so if they're all just notes-to-self that's fine too.

fmease · 2023-03-22T12:10:26Z

can you change these FIXME(fmease) to FIXME(inherent-associated-types)

👍

I tagged most of the FIXMEs with my name to signal that I want to see them solved in this PR. However, there are definitely several of those that should instead be inherent_associated_types.

…-in-self-ty, r=compiler-errors Use region-erased self type during IAT selection Split off from rust-lang#109410 as discussed. Fixes rust-lang#109299. Re UI test: I use a reproducer of rust-lang#109299 that contains a name resolution error instead of reproducer [`regionck-2.rs`](https://github.com/rust-lang/rust/blob/fc7ed4af165c27ab5914b93251194f826920cc65/tests/ui/associated-inherent-types/regionck-2.rs) (as found in the `AliasKind::Inherent` PR) since it would (incorrectly) pass typeck in this PR due to the lack of regionck and I'd rather not make *that* a regression test (with or without `known-bug`). ``@rustbot`` label F-inherent_associated_types r? ``@compiler-errors``

bors · 2023-03-24T09:38:27Z

☔ The latest upstream changes (presumably #109552) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2023-03-29T02:25:00Z

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

compiler-errors · 2023-05-08T03:11:31Z

@bors r+

This is fine for now, given that this is probably not the final approach and we've identified all of the existing limitations with FIXMEs that should be reviewed sometime between now and stabilization (which I assume is far off in the future lol).

bors · 2023-05-08T03:11:33Z

📌 Commit cd6dec3 has been approved by compiler-errors

It is now in the queue for this repository.

…mpiler-errors Rollup of 6 pull requests Successful merges: - rust-lang#104070 (Prevent aborting guard from aborting the process in a forced unwind) - rust-lang#109410 (Introduce `AliasKind::Inherent` for inherent associated types) - rust-lang#111004 (Migrate `mir_transform` to translatable diagnostics) - rust-lang#111118 (Suggest struct when we get colon in fileds in enum) - rust-lang#111170 (Diagnostic args are still args if they're documented) - rust-lang#111354 (Fix miscompilation when calling default methods on `Future`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-lang/rust#109410

The bump adds rustdoc JSON support for inherent associated types [1]. Note that that is only supported in unstable Rust, so it is too early for us to add a regression test. [1]: rust-lang/rust#109410

…illaumeGomez rustdoc-json: Add tests for `#![feature(inherent_associated_types)]` Follow up to rust-lang#109410, CC `@fmease` r? `@GuillaumeGomez`

The bump adds rustdoc JSON support for inherent associated types [1]. Note that that is only supported in unstable Rust, so it is too early for us to add a regression test. [1]: rust-lang/rust#109410

…s, r=compiler-errors Exclude inherent projections from some alias type `match`es Updating (hopefully) all remaining `match`es which I overlooked to update when adding `AliasKind::Inherent` in rust-lang#109410. Fixes rust-lang#111399. Sadly the regression test is a clippy test instead of a rustc one as I don't know of another way to test that a trait bound like `Ty::InhProj: Trait` doesn't cause a crash without reaching a cycle error first (this is getting old ^^'). `@rustbot` label F-inherent_associated_types r? `@compiler-errors`

…compiler-errors Introduce `AliasKind::Inherent` for inherent associated types Allows us to check (possibly generic) inherent associated types for well-formedness. Type inference now also works properly. Follow-up to rust-lang#105961. Supersedes rust-lang#108430. Fixes rust-lang#106722. Fixes rust-lang#108957. Fixes rust-lang#109768. Fixes rust-lang#109789. Fixes rust-lang#109790. ~Not to be merged before rust-lang#108860 (`AliasKind::Weak`).~ CC `@jackh726` r? `@compiler-errors` `@rustbot` label T-types F-inherent_associated_types

rustbot assigned compiler-errors Mar 20, 2023

rustbot added F-inherent_associated_types `#![feature(inherent_associated_types)]` T-types Relevant to the types team, which will review and decide on the PR/issue. labels Mar 20, 2023

fmease force-pushed the iat-alias-kind-inherent branch from 6e8db37 to 1c2dafd Compare March 20, 2023 19:26

compiler-errors reviewed Mar 20, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

fmease force-pushed the iat-alias-kind-inherent branch from 1c2dafd to bc1001c Compare March 20, 2023 22:02

This comment has been minimized.

Sign in to view

fmease force-pushed the iat-alias-kind-inherent branch from bc1001c to fc7ed4a Compare March 21, 2023 00:48

fmease mentioned this pull request Mar 21, 2023

Use region-erased self type during IAT selection #109423

Merged

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2023

fmease force-pushed the iat-alias-kind-inherent branch from fc7ed4a to 3e187fc Compare March 21, 2023 15:27

fmease force-pushed the iat-alias-kind-inherent branch from 3e187fc to 97600b0 Compare March 22, 2023 01:17

fmease mentioned this pull request Mar 22, 2023

Rustdoc does not escape GAT arguments when it fails to compute the href link for the trait #109488

Closed

fmease force-pushed the iat-alias-kind-inherent branch from 97600b0 to d2bd1b6 Compare March 29, 2023 02:24

rustbot added the A-rustdoc-json Area: Rustdoc JSON backend label Mar 29, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2023

compiler-errors mentioned this pull request May 8, 2023

Rollup of 6 pull requests #111358

Merged

bors merged commit 29ac429 into rust-lang:master May 8, 2023

rustbot added this to the 1.71.0 milestone May 8, 2023

fmease deleted the iat-alias-kind-inherent branch May 9, 2023 00:08

JohnTitor mentioned this pull request May 9, 2023

ICE: unexpected type encountered in variance inference: _ #109071

Closed

xFrednet mentioned this pull request May 9, 2023

Bump nightly -> 2023-06-01 rust-marker/marker#128

Closed

This was referenced May 9, 2023

ICE: expected const for .. but found Type(..) when substituting #111397

Closed

ICE: clippy: inherent_associated_types item_bounds called on DefId(0:6 ~ ambiguous_inherent_assoc_ty #111399

Closed

aDotInTheVoid added a commit to rust-lang/rustdoc-types that referenced this pull request May 13, 2023

v0.21.0

933c7f0

rust-lang/rust#109410

aDotInTheVoid mentioned this pull request May 13, 2023

Automate updating/publishing rust-lang/rustdoc-types#18

Open

9 tasks

Enselic mentioned this pull request May 13, 2023

Add playground nightly_api test api cargo-public-api/cargo-public-api#420

Merged

aDotInTheVoid mentioned this pull request May 13, 2023

rustdoc-json: Add tests for #![feature(inherent_associated_types)] #111534

Merged

Enselic mentioned this pull request May 13, 2023

Bump rustdoc-types from 0.20.0 to 0.21.0 (nightly-2023-05-09) cargo-public-api/cargo-public-api#421

Merged

fmease mentioned this pull request May 17, 2023

Exclude inherent projections from some alias type matches #111695

Merged

matthiaskrgr mentioned this pull request May 23, 2023

ICE: inherent_associated_types: Unexpected parameter Type(..) ... when substituting in region.. #111879

Closed

fmease mentioned this pull request May 30, 2023

Tracking issue for inherent associated types #8995

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce `AliasKind::Inherent` for inherent associated types #109410

Introduce `AliasKind::Inherent` for inherent associated types #109410

fmease commented Mar 20, 2023 •

edited

Loading

rustbot commented Mar 20, 2023

compiler-errors left a comment •

edited

Loading

compiler-errors Mar 20, 2023

compiler-errors Mar 20, 2023

fmease Mar 22, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

compiler-errors commented Mar 22, 2023 •

edited

Loading

fmease commented Mar 22, 2023 •

edited

Loading

bors commented Mar 24, 2023

rustbot commented Mar 29, 2023

compiler-errors commented May 8, 2023

bors commented May 8, 2023

Introduce AliasKind::Inherent for inherent associated types #109410

Introduce AliasKind::Inherent for inherent associated types #109410

Conversation

fmease commented Mar 20, 2023 • edited Loading

rustbot commented Mar 20, 2023

compiler-errors left a comment • edited Loading

Choose a reason for hiding this comment

compiler-errors Mar 20, 2023

Choose a reason for hiding this comment

compiler-errors Mar 20, 2023

Choose a reason for hiding this comment

fmease Mar 22, 2023

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment was marked as resolved.

compiler-errors commented Mar 22, 2023 • edited Loading

fmease commented Mar 22, 2023 • edited Loading

bors commented Mar 24, 2023

rustbot commented Mar 29, 2023

compiler-errors commented May 8, 2023

bors commented May 8, 2023

Introduce `AliasKind::Inherent` for inherent associated types #109410

Introduce `AliasKind::Inherent` for inherent associated types #109410

fmease commented Mar 20, 2023 •

edited

Loading

compiler-errors left a comment •

edited

Loading

compiler-errors commented Mar 22, 2023 •

edited

Loading

fmease commented Mar 22, 2023 •

edited

Loading