Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #109496

Merged
merged 27 commits into from
Mar 22, 2023
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
0d8a0c5
Rename LinesAnyMap to LinesMap
KamilaBorowska Aug 9, 2022
cef81dc
Fix handling of trailing bare CR in str::lines
KamilaBorowska Aug 9, 2022
102c8fa
Render source page layout with Askama
clubby789 Mar 12, 2023
6639538
Remove VecMap
compiler-errors Mar 17, 2023
27e9ee9
move Option::as_slice to intrinsic
llogiq Mar 15, 2023
2ec7f6c
refactor `fn bootstrap::builder::Builder::compiler_for`
onur-ozkan Mar 18, 2023
572c56c
Update links for custom discriminants.
ehuss Jan 19, 2023
83dec62
Add a layout argument to `enforce_validity`.
oli-obk Mar 21, 2023
f066d67
Detect uninhabited types early in const eval.
oli-obk Mar 21, 2023
d3a5541
rustdoc: Cleanup parent module tracking for doc links
petrochenkov Mar 18, 2023
0f45d85
rustdoc: Factor out some doc link resolution code into a separate fun…
petrochenkov Mar 21, 2023
4212c1b
Add `safe` to number rendering
clubby789 Mar 21, 2023
364a5d4
Do not consider synthesized RPITITs on missing items checks
spastorino Mar 20, 2023
c1f3529
Always encode RPITITs
spastorino Mar 20, 2023
c3e6f68
RPITITs are DefKind::Opaque with new lowering strategy
compiler-errors Mar 20, 2023
df034b0
Change text -> rust,ignore highlighting in sanitizer.md
tgross35 Mar 10, 2023
d694f47
Rollup merge of #100311 - xfix:lines-fix-handling-of-bare-cr, r=Chris…
Dylan-DPC Mar 22, 2023
59d9cbf
Rollup merge of #108997 - tgross35:patch-1, r=JohnTitor
Dylan-DPC Mar 22, 2023
14d0646
Rollup merge of #109179 - llogiq:intrinsically-option-as-slice, r=eholk
Dylan-DPC Mar 22, 2023
d8543ab
Rollup merge of #109187 - clubby789:askama-source, r=GuillaumeGomez
Dylan-DPC Mar 22, 2023
70918ec
Rollup merge of #109280 - compiler-errors:no-vec-map, r=Mark-Simulacrum
Dylan-DPC Mar 22, 2023
7a57d88
Rollup merge of #109295 - ozkanonur:issue-109286, r=ozkanonur
Dylan-DPC Mar 22, 2023
af3bd22
Rollup merge of #109312 - petrochenkov:docice5, r=GuillaumeGomez
Dylan-DPC Mar 22, 2023
8ce52b7
Rollup merge of #109317 - ehuss:discriminant-link-fix, r=Nilstrieb
Dylan-DPC Mar 22, 2023
b9151b2
Rollup merge of #109405 - compiler-errors:rpitit-as-opaques, r=spasto…
Dylan-DPC Mar 22, 2023
031640c
Rollup merge of #109414 - spastorino:new-rpitit-16, r=compiler-errors
Dylan-DPC Mar 22, 2023
eda88a3
Rollup merge of #109435 - oli-obk:🇨🇭🥚_copy_op, r=RalfJung
Dylan-DPC Mar 22, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not consider synthesized RPITITs on missing items checks
spastorino committed Mar 21, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 364a5d4b542618b6db6cfab3f4a0c31d04020765
5 changes: 4 additions & 1 deletion compiler/rustc_hir_analysis/src/check/mod.rs
Original file line number Diff line number Diff line change
@@ -202,8 +202,11 @@ fn missing_items_err(
missing_items: &[ty::AssocItem],
full_impl_span: Span,
) {
let missing_items =
missing_items.iter().filter(|trait_item| tcx.opt_rpitit_info(trait_item.def_id).is_none());

let missing_items_msg = missing_items
.iter()
.clone()
.map(|trait_item| trait_item.name.to_string())
.collect::<Vec<_>>()
.join("`, `");
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
warning: the feature `return_position_impl_trait_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
--> $DIR/dont-project-to-rpitit-with-no-value.rs:1:12
--> $DIR/dont-project-to-rpitit-with-no-value.rs:4:12
|
LL | #![feature(return_position_impl_trait_in_trait)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -8,7 +8,7 @@ LL | #![feature(return_position_impl_trait_in_trait)]
= note: `#[warn(incomplete_features)]` on by default

error[E0046]: not all trait items implemented, missing: `foo`
--> $DIR/dont-project-to-rpitit-with-no-value.rs:9:1
--> $DIR/dont-project-to-rpitit-with-no-value.rs:12:1
|
LL | fn foo(&self) -> impl Sized;
| ---------------------------- `foo` from trait
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
warning: the feature `return_position_impl_trait_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
--> $DIR/dont-project-to-rpitit-with-no-value.rs:4:12
|
LL | #![feature(return_position_impl_trait_in_trait)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #91611 <https://github.com/rust-lang/rust/issues/91611> for more information
= note: `#[warn(incomplete_features)]` on by default

error[E0046]: not all trait items implemented, missing: `foo`
--> $DIR/dont-project-to-rpitit-with-no-value.rs:12:1
|
LL | fn foo(&self) -> impl Sized;
| ---------------------------- `foo` from trait
...
LL | impl MyTrait for i32 {
| ^^^^^^^^^^^^^^^^^^^^ missing `foo` in implementation

error: aborting due to previous error; 1 warning emitted

For more information about this error, try `rustc --explain E0046`.
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// [next] compile-flags: -Zlower-impl-trait-in-trait-to-assoc-ty
// revisions: current next

#![feature(return_position_impl_trait_in_trait)]
//~^ WARN the feature `return_position_impl_trait_in_trait` is incomplete

@@ -7,7 +10,7 @@ trait MyTrait {
}

impl MyTrait for i32 {
//~^ ERROR not all trait items implemented, missing: `foo`
//~^ ERROR not all trait items implemented, missing: `foo`
fn bar(&self) -> impl Sized {
self.foo()
}