Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #109516

Closed
wants to merge 24 commits into from

Commits on Mar 16, 2023

  1. Configuration menu
    Copy the full SHA
    f28f77f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d99e01f View commit details
    Browse the repository at this point in the history
  3. resolve: Use item_name and opt_parent in Resolver::get_module

    This is a cleanup that doesn't introduce new query calls, but this way `def_key` is decoded twice which may matter for performance or may not
    petrochenkov committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    52c7397 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    18b59f5 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Configuration menu
    Copy the full SHA
    009ed88 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c2ee33 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e7472f View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Configuration menu
    Copy the full SHA
    ec25f08 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b537e6b View commit details
    Browse the repository at this point in the history
  3. Stabilize arc_into_inner and rc_into_inner.

    Includes resolving the FIXMEs in the documentation,
    and some very minor documentation improvements.
    steffahn committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    e8be3d2 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Configuration menu
    Copy the full SHA
    3f7aeb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5dc3fd7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a36a09 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f6fd754 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    244cdaa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e5189cc View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#108541 - compiler-errors:lol-nested-rpits, …

    …r=oli-obk
    
    Suppress `opaque_hidden_inferred_bound` for nested RPITs
    
    They trigger too much, making repos like linkerd/linkerd2-proxy#2275 sad.
    
    Ideally, at least for RPITs (and probably TAITs?), specifically when we have `impl Trait<Assoc = impl ..>`, that nested opaque should have the necessary `Assoc` item bounds elaborated into its own item bounds. But that's another story.
    
    r? ``@oli-obk``
    matthiaskrgr authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    484ef47 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#108961 - compiler-errors:refine-ct-errors, …

    …r=BoxyUwU
    
    Refine error spans for const args in hir typeck
    
    Improve just a couple of error messages having to do with mismatched consts.
    
    r? ``@ghost`` i'll put this up when the dependent commits are merged
    matthiaskrgr authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    4213fac View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#109137 - petrochenkov:qcstore2, r=cjgillot

    resolve: Querify most cstore access methods (subset 2)
    
    These changes are less likely to cause perf regressions than the rest of rust-lang#108346.
    matthiaskrgr authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    2c9ac4a View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#109380 - Randl:patch-1, r=oli-obk

    add `known-bug` test for unsoundness issue
    
    Test for rust-lang#97156
    matthiaskrgr authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    0dac4a1 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#109462 - compiler-errors:alias-relate, r=Bo…

    …xyUwU,lcnr
    
    Make alias-eq have a relation direction (and rename it to alias-relate)
    
    Emitting an "alias-eq" is too strict in some situations, since we don't always want strict equality between a projection and rigid ty. Adds a relation direction.
    
    * I could probably just reuse this [`RelationDir`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_infer/infer/combine/enum.RelationDir.html) -- happy to uplift that struct into middle and use that instead, but I didn't feel compelled to... 🤷
    * Some of the matching in `compute_alias_relate_goal` is a bit verbose -- I guess I could simplify it by using [`At::relate`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_infer/infer/at/struct.At.html#method.relate) and mapping the relation-dir to a variance.
    * Alternatively, I coulld simplify things by making more helper functions on `EvalCtxt` (e.g. `EvalCtxt::relate_with_direction(T, T)` that also does the nested goal registration). No preference.
    
    r? ``@lcnr`` cc ``@BoxyUwU`` though boxy can claim it if she wants
    NOTE: first commit is all the changes, the second is just renaming stuff
    matthiaskrgr authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    80bfee1 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#109475 - scottmcm:simpler-shifts, r=WaffleL…

    …apkin
    
    Simpler checked shifts in MIR building
    
    Doing masking to check unsigned shift amounts is overcomplicated; just comparing the shift directly saves a statement and a temporary, as well as is much easier to read as a human.  And shifting by unsigned is the canonical case -- notably, all the library shifting methods (that don't support every type) take shift RHSs as `u32` -- so we might as well make that simpler since it's easy to do so.
    
    This PR also changes *signed* shift amounts to `IntToInt` casts and then uses the same check as for unsigned.  The bit-masking is a nice trick, but for example LLVM actually canonicalizes it to an unsigned comparison anyway <https://rust.godbolt.org/z/8h59fMGT4> so I don't think it's worth the effort and the extra `Constant`.  (If MIR's `assert` was `assert_nz` then the masking might make sense, but when the `!=` uses another statement I think the comparison is better.)
    
    To review, I suggest looking at rust-lang@2ee0468 first -- that's the interesting code change and has a MIR diff.
    
    My favourite part of the diff:
    ```diff
    -        _20 = BitAnd(_19, const 340282366920938463463374607431768211448_u128); // scope 0 at $DIR/shifts.rs:+2:34: +2:44
    -        _21 = Ne(move _20, const 0_u128); // scope 0 at $DIR/shifts.rs:+2:34: +2:44
    -        assert(!move _21, "attempt to shift right by `{}`, which would overflow", _19) -> [success: bb3, unwind: bb7]; // scope 0 at $DIR/shifts.rs:+2:34: +2:44
    +        _18 = Lt(_17, const 8_u128);     // scope 0 at $DIR/shifts.rs:+2:34: +2:44
    +        assert(move _18, "attempt to shift right by `{}`, which would overflow", _17) -> [success: bb3, unwind: bb7]; // scope 0 at $DIR/shifts.rs:+2:34: +2:44
    ```
    matthiaskrgr authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    2603ef0 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#109504 - steffahn:stabilize_a_rc_into_inner…

    …, r=joshtriplett
    
    Stabilize `arc_into_inner` and `rc_into_inner`.
    
    Stabilize the `arc_into_inner` and `rc_into_inner` library features and thus close rust-lang#106894.
    
    The changes in this PR also resolve the FIXMEs for adjusting the documentation upon stabilization, and I’ve additionally included some very minor documentation improvements.
    
    ``@rustbot`` label +T-libs-api -T-libs
    matthiaskrgr authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    9ee96c8 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#109506 - BoxyUwU:debugable_bound_var_printi…

    …ng, r=compiler-errors
    
    make param bound vars visibly bound vars with -Zverbose
    
    I was trying to debug some type/const bound var stuff and it was shockingly tricky due to the fact that even with `-Zverbose` enabled the `T` in `for<T> T: Trait` prints as `T` making it seem like its `TyKind::Param` when it is infact `TyKind::Bound`. This PR "fixes" this when `-Zverbose` is set to allow rendering it as `^T` or `^1_T` depending on binder depth.
    
    r? ``@compiler-errors``
    matthiaskrgr authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    eeeb44e View commit details
    Browse the repository at this point in the history