Skip to content

[experiment] refactor WorkerLocal into enum for parallel compiler #109528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[experiment] refactor WorkerLocal into enum for parallel compiler #109528

wants to merge 1 commit into from

Conversation

deltragon
Copy link
Contributor

Based on my suggestion in #109478 (comment).

Co-authored-by: SparrowLii <liyuan179@huawei.com>
Co-authored-by: deltragon <mel@dafert.at>
@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @WaffleLapkin (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 23, 2023
@deltragon
Copy link
Contributor Author

@SparrowLii Would it be possible to kick off a perf run for this?

@SparrowLii
Copy link
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 23, 2023
@bors
Copy link
Collaborator

bors commented Mar 23, 2023

⌛ Trying commit e33599c with merge 0f5c0e5435b325405011cb480748a99a9633e244...

@SparrowLii
Copy link
Member

@SparrowLii Would it be possible to kick off a perf run for this?

Yeah sure. Sorry for the missing

@deltragon
Copy link
Contributor Author

Thanks!

@bors
Copy link
Collaborator

bors commented Mar 23, 2023

☀️ Try build successful - checks-actions
Build commit: 0f5c0e5435b325405011cb480748a99a9633e244 (0f5c0e5435b325405011cb480748a99a9633e244)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0f5c0e5435b325405011cb480748a99a9633e244): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.8% [3.8%, 3.8%] 1
Regressions ❌
(secondary)
1.3% [0.4%, 3.8%] 9
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.5% [-0.5%, -0.5%] 1
All ❌✅ (primary) 3.8% [3.8%, 3.8%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.7% [0.4%, 1.3%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-1.3%, -0.5%] 3
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 24, 2023
@SparrowLii
Copy link
Member

I think the perf result in #109528 is nice(There is some increase in wall-time, but it has little effect on global effects). Thanks!

@deltragon
Copy link
Contributor Author

Thank you, for your work on the parallel compiler!

@deltragon deltragon closed this Mar 24, 2023
@WaffleLapkin WaffleLapkin removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants