-
Notifications
You must be signed in to change notification settings - Fork 13.3k
[experiment] refactor WorkerLocal
into enum for parallel compiler
#109528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: SparrowLii <liyuan179@huawei.com> Co-authored-by: deltragon <mel@dafert.at>
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @WaffleLapkin (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
@SparrowLii Would it be possible to kick off a perf run for this? |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit e33599c with merge 0f5c0e5435b325405011cb480748a99a9633e244... |
Yeah sure. Sorry for the missing |
Thanks! |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (0f5c0e5435b325405011cb480748a99a9633e244): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
I think the perf result in #109528 is nice(There is some increase in wall-time, but it has little effect on global effects). Thanks! |
Thank you, for your work on the parallel compiler! |
Based on my suggestion in #109478 (comment).