Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean and tidy some traits #10967

Merged
merged 2 commits into from
Dec 17, 2013
Merged

Clean and tidy some traits #10967

merged 2 commits into from
Dec 17, 2013

Commits on Dec 14, 2013

  1. Remove {As,Into,To}{Option,Either,Result} traits. 

    Expanded, that is:

- `AsOption`
- `IntoOption`
- `ToOption`
- `AsEither`
- `IntoEither`
- `ToEither`
- `AsResult`
- `IntoResult`
- `ToResult`

These were defined for each other but never *used* anywhere. They are
all trivial and so removal will have negligible effect upon anyone.
`Either` has fallen out of favour (and its implementation of these
traits of dubious semantics), `Option<T>` → `Result<T, ()>` was never
really useful and `Result<T, E>` → `Option<T>` should now be done with
`Result.ok()` (mirrored with `Result.err()` for even more usefulness).

In summary, there's really no point in any of these remaining.
    @chris-morgan
    chris-morgan committed Dec 14, 2013
    Configuration menu
    Copy the full SHA
    529f915 View commit details
    Browse the repository at this point in the history

  2. Rename To{Str,Bytes}Consume traits to Into*. 

    That is:

- `ToStrConsume` → `IntoStr`;
- `ToBytesConsume` → `IntoBytes`.
    @chris-morgan
    chris-morgan committed Dec 14, 2013
    5 Configuration menu
    Copy the full SHA
    b76997f View commit details
    Browse the repository at this point in the history