Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the heuristics IsTerminal uses on Windows #109687

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Document the heuristics IsTerminal uses on Windows #109687

merged 2 commits into from
Mar 28, 2023

Conversation

joshtriplett
Copy link
Member

Suggested by @BurntSushi.

@rustbot
Copy link
Collaborator

rustbot commented Mar 28, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 28, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 28, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@joshtriplett
Copy link
Member Author

r? @BurntSushi

@rustbot rustbot assigned BurntSushi and unassigned thomcc Mar 28, 2023
@joshtriplett joshtriplett mentioned this pull request Mar 28, 2023
Closed
3 tasks
@thomcc
Copy link
Member

thomcc commented Mar 28, 2023

Can you leave a link to https://doc.rust-lang.org/nightly/std/io/index.html#platform-specific-behavior and note that this documentation is not a guarantee and that the behavior may change in the future? (See here among many other place sfor another example of where we have such links).

BurntSushi
BurntSushi approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thank you!

@joshtriplett
Copy link
Member Author

@thomcc Done.

@joshtriplett
Copy link
Member Author

@BurntSushi Thanks!

@bors r=BurntSushi rollup

@bors
Copy link
Contributor

bors commented Mar 28, 2023

📌 Commit b38732f has been approved by BurntSushi

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2023
@bors
Auto merge of rust-lang#109690 - matthiaskrgr:rollup-6p5m0es, r=matth…
f418859 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#108548 (Clarify the 'use a constant in a pattern' error message)
 - rust-lang#109565 (Improve documentation for E0223)
 - rust-lang#109661 (Fix LVI test post LLVM 16 update)
 - rust-lang#109667 (Always set `RUSTC_BOOTSTRAP` with `x doc`)
 - rust-lang#109669 (Update books)
 - rust-lang#109678 (Don't shadow the `dep_node` var in `incremental_verify_ich_failed`)
 - rust-lang#109682 (Add `#[inline]` to CStr trait implementations)
 - rust-lang#109685 (Make doc comment a little bit more accurate)
 - rust-lang#109687 (Document the heuristics IsTerminal uses on Windows)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a694960 into rust-lang:master Mar 28, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees

@BurntSushi BurntSushi

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
5 participants
@joshtriplett @rustbot @thomcc @bors @BurntSushi