Support explicit names in pkgid attributes #10972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it still possible to identify packages via |
|
@alexcrichton Yes. The old behavior is preserved. The old unit tests are still there, though they were modified because the way pkgid.path is handled is changed. This is fine since nothing in rustc uses this yet. |
|
@alexcrichton Rebased. re-r? Did I answer your questions? |
|
Removed new syntax in crates since that won't bootstrap. Doh! |
Previously the a pkgid of `foo/rust-bar#1.0` implied a crate name of `rust-bar` and didn't allow this to be overridden. Now you can override the inferred crate name with `foo/rust-bar#bar:1.0`.
|
Removed some stray trailing whitespace. |
bors
added a commit
that referenced
this pull request
Dec 17, 2013
This change extends the pkgid attribute to allow of explicit crate names, instead of always inferring them based on the path. This means that if your GitHub repo is called `rust-foo`, you can have your pkgid set your library name to `foo`. You'd do this with a pkgid attribute like `github.com/somewhere/rust-foo#foo:1.0`. This is half of the fix for #10922.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 9, 2025
`asked to assemble constituent types of unexpected type: Binder(Foo, [])` Fixes rust-lang#10972
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 9, 2025
`asked to assemble constituent types of unexpected type: Binder(Foo, [])` Fixes rust-lang#10972 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the pkgid attribute to allow of explicit crate names, instead of always inferring them based on the path. This means that if your GitHub repo is called
rust-foo, you can have your pkgid set your library name tofoo. You'd do this with a pkgid attribute likegithub.com/somewhere/rust-foo#foo:1.0.This is half of the fix for #10922.