Canonicalize float var as float in new solver #109749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rust-cloud-vms
bot
force-pushed
the
new-solver-float-var
branch
from
01a23e2
to
977694a
Compare
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 30, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#106985 (Enhanced doucmentation of binary search methods for `slice` and `VecDeque` for unsorted instances) - rust-lang#109509 (compiletest: Don't allow tests with overlapping prefix names) - rust-lang#109719 (RELEASES: Add "Only support Android NDK 25 or newer" to 1.68.0) - rust-lang#109748 (Don't ICE on `DiscriminantKind` projection in new solver) - rust-lang#109749 (Canonicalize float var as float in new solver) - rust-lang#109761 (Drop binutils on powerpc-unknown-freebsd) - rust-lang#109766 (Fix title for openharmony.md) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo in new canonicalizer -- we should be canonicalizing float vars as
CanonicalTyVarKind::Float, notCanonicalTyVarKind::Int.Fixes compiler-errors/next-solver-hir-issues#9