Skip to content

Remove mention of missing_doc_code_examples lint from rustdoc book #109767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GuillaumeGomez
Copy link
Member

Fixes #109601.

r? @notriddle

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2023
@notriddle
Copy link
Contributor

Please add it to the unstable features section? https://doc.rust-lang.org/nightly/rustdoc/unstable-features.html

@GuillaumeGomez GuillaumeGomez force-pushed the rm-mention-missing_doc_code_examples branch from 2203378 to b85fcf5 Compare March 30, 2023 14:49
@GuillaumeGomez
Copy link
Member Author

I added it into the unstable features.

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 7, 2023

📌 Commit b85fcf5 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2023
@bors
Copy link
Collaborator

bors commented Apr 8, 2023

⌛ Testing commit b85fcf5 with merge efccc435ff418d6f3198b47d532aa4a4de93adde...

@bors
Copy link
Collaborator

bors commented Apr 8, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 8, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@GuillaumeGomez
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2023
@bors
Copy link
Collaborator

bors commented Apr 8, 2023

⌛ Testing commit b85fcf5 with merge 4f87a63...

@bors
Copy link
Collaborator

bors commented Apr 8, 2023

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 4f87a63 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Apr 8, 2023

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 4f87a63 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 8, 2023
@bors bors merged commit 4f87a63 into rust-lang:master Apr 8, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 8, 2023
@GuillaumeGomez GuillaumeGomez deleted the rm-mention-missing_doc_code_examples branch April 8, 2023 16:04
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4f87a63): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.8% [-3.2%, -2.5%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stable Rustdoc Book suggests missing_doc_code_examples, which is unstable
6 participants