-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak output for 'add line' suggestion #109786
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
For the "add context line" part of this PR, we could alternatively peek at the suggestion and see if it starts with |
c59590f
to
00013ba
Compare
☔ The latest upstream changes (presumably #109884) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can do something like... checking that the span of the suggestion isn't DUMMY_SP
(to avoid those use
suggestions) or that the suggestion starts with #[derive...
? Thoughts?
We already check for |
Maybe we should suppress this behavior if the suggestion ends in two newlines
instead of:
|
00013ba
to
97258fe
Compare
I did a quick check for starts with |
97258fe
to
def404a
Compare
☔ The latest upstream changes (presumably #110214) made this pull request unmergeable. Please resolve the merge conflicts. |
r=me after rebase @rustbot author |
def404a
to
9fadcc1
Compare
@bors r=compiler-errors |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d37e2f7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Closes #108174