Skip to content

Emit feature error for parenthesized generics in associated type bounds #109914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2023
Merged

Emit feature error for parenthesized generics in associated type bounds #109914

merged 1 commit into from
Apr 4, 2023

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Apr 3, 2023 •
edited
Loading

We don't actually do AST->HIR lowering with some -Zunpretty flags, so it's not correct to just delay a bug instead of emitting a feature error.

Some diagnostics regressed because of the new errors, but oh well. 🤷

Fixes #109898

@rustbot
Copy link
Collaborator

rustbot commented Apr 3, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 3, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Apr 4, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 4, 2023

📌 Commit ab0b935 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2023
@aliemjay aliemjay mentioned this pull request Apr 4, 2023
Closed
@compiler-errors compiler-errors mentioned this pull request Apr 4, 2023
Merged
@bors bors merged commit a5c395e into rust-lang:master Apr 4, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 4, 2023
@compiler-errors compiler-errors deleted the rtn-bad-parens branch August 11, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

ICE: should have emitted a parenthesized generics error, -Zunpretty
4 participants
@compiler-errors @rustbot @oli-obk @bors