Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove u32 on BrAnon and BoundTyKind::Anon in favor of BoundVar on Placeholder types #110036

Merged
merged 6 commits into from
Apr 7, 2023

Conversation

jackh726
Copy link
Member

@jackh726 jackh726 commented Apr 7, 2023

r? @nnethercote

Better alternative to #110025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 7, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 7, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@jackh726
Copy link
Member Author

jackh726 commented Apr 7, 2023

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 7, 2023
@bors
Copy link
Contributor

bors commented Apr 7, 2023

⌛ Trying commit b15195a with merge 556dcffdd3e6e31e4521e798443b02e2f28745f6...

@bors
Copy link
Contributor

bors commented Apr 7, 2023

☀️ Try build successful - checks-actions
Build commit: 556dcffdd3e6e31e4521e798443b02e2f28745f6 (556dcffdd3e6e31e4521e798443b02e2f28745f6)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (556dcffdd3e6e31e4521e798443b02e2f28745f6): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [1.7%, 3.1%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.4% [-5.1%, -3.7%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.6% [-2.9%, -2.3%] 3
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 7, 2023
@nnethercote
Copy link
Contributor

Thanks! I would still like the new size assertion from the first commit in #110025. (I think this change reduces the size of RegionKind from 32 bytes to 28 bytes on x86-64, but it's hard to know for sure.) You could add it here, or you could just merge this and then I can adjust #110025 and do it as a follow-up. I'll let you decide.

@bors delegate=jackh726

@bors
Copy link
Contributor

bors commented Apr 7, 2023

✌️ @jackh726 can now approve this pull request

@jackh726
Copy link
Member Author

jackh726 commented Apr 7, 2023

I've cherry-picked your commit from #110025. Indeed the size is reduced from 32 to 28.

@bors r=nnethercote

@bors
Copy link
Contributor

bors commented Apr 7, 2023

📌 Commit f08f154 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2023
@bors
Copy link
Contributor

bors commented Apr 7, 2023

⌛ Testing commit f08f154 with merge 9452402...

@bors
Copy link
Contributor

bors commented Apr 7, 2023

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing 9452402 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 7, 2023
@bors bors merged commit 9452402 into rust-lang:master Apr 7, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 7, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9452402): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [1.7%, 2.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.1% [-5.1%, -3.1%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.4%, -3.1%] 2
All ❌✅ (primary) - - 0

@jackh726 jackh726 deleted the placeholder_boundvar branch April 7, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants