-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erase regions when confirming transmutability candidate #110038
Erase regions when confirming transmutability candidate #110038
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
b1df07d
to
c46328a
Compare
r? @scottmcm to balance #110021 (comment) |
This looks plausible to me -- not having the r? types |
r? types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, then r=me
c46328a
to
f6bfb4b
Compare
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
Addressed the comment nit and rebased past a PR that changed the transmutability API slightly (no more binder for an argument). We lose a @bors r=lcnr rollup |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#110038 (Erase regions when confirming transmutability candidate) - rust-lang#110341 (rustdoc: stop passing a title to `replaceState` second argument) - rust-lang#110388 (Add a message for if an overflow occurs in `core::intrinsics::is_nonoverlapping`.) - rust-lang#110404 (fix clippy::toplevel_ref_arg and ::manual_map) - rust-lang#110421 (Spelling librustdoc) - rust-lang#110423 (Spelling srcdoc) - rust-lang#110433 (Windows: map a few more error codes to ErrorKind) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes an ICE where we call
layout_of
on a type with infer regions.