Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump thiserror to use syn 2.0 #110081

Merged
merged 1 commit into from
May 28, 2023
Merged

bump thiserror to use syn 2.0 #110081

merged 1 commit into from
May 28, 2023

Conversation

fee1-dead
Copy link
Member

cc #109302

@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2023

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

@fee1-dead fee1-dead mentioned this pull request Apr 8, 2023
Open
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 9, 2023

📌 Commit 55219b3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 9, 2023
@matthiaskrgr
Rollup merge of rust-lang#110081 - fee1-dead-contrib:bump-thiserror, …
0c72a07 
…r=Mark-Simulacrum

bump `thiserror` to use syn 2.0

cc rust-lang#109302
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 9, 2023
Closed
@matthiaskrgr
Copy link
Member

@bors r- failed in a rollup
#110119

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2023
@w-flo
Copy link

w-flo commented May 10, 2023

Will this work now that rustc-workspace-hack is gone?

@fee1-dead
Copy link
Member Author

since rustc-workspace-hack is gone, this should work

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented May 28, 2023

📌 Commit ab7c4b7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 28, 2023
@fee1-dead fee1-dead mentioned this pull request May 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 28, 2023
@bors
Auto merge of rust-lang#112028 - fee1-dead-contrib:rollup-4xxzxd0, r=…
ddad057 
…fee1-dead

Rollup of 2 pull requests

Successful merges:

 - rust-lang#110081 (bump `thiserror` to use syn 2.0)
 - rust-lang#112005 (Migrate `item_foreign_type` to Askama )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ea1c3e6 into rust-lang:master May 28, 2023
@rustbot rustbot added this to the 1.72.0 milestone May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
6 participants
@fee1-dead @rustbot @Mark-Simulacrum @bors @matthiaskrgr @w-flo