Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renaming of ignore-git to changelog #110108

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

duckymirror
Copy link
Contributor

bootstrap's ignore-git option has been renamed to omit-git-hash in #110059. This PR adds this change to the CHANGELOG.md. See also #110020 (comment).

@rustbot
Copy link
Collaborator

rustbot commented Apr 9, 2023

r? @ozkanonur

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 9, 2023
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

will queue it once the CI is green

@onur-ozkan
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 9, 2023

📌 Commit 3fcc007 has been approved by ozkanonur

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 9, 2023
…gelog, r=ozkanonur

Add renaming of ignore-git to changelog

`bootstrap`'s `ignore-git` option has been renamed to `omit-git-hash` in rust-lang#110059. This PR adds this change to the `CHANGELOG.md`. See also rust-lang#110020 (comment).
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#108843 (Instantiate instead of erasing binder when probing param methods)
 - rust-lang#109985 (Add little `is_test_crate` function)
 - rust-lang#110028 (Migrate `rustc_hir_analysis` to session diagnostic [Part 3])
 - rust-lang#110095 (Migrate remainder of rustc_ty_utils to `SessionDiagnostic`)
 - rust-lang#110108 (Add renaming of ignore-git to changelog)
 - rust-lang#110114 (compiletest: Give a better error message if `node` isn't installed)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7822064 into rust-lang:master Apr 10, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 10, 2023
@duckymirror duckymirror deleted the rename-ignore-git-changelog branch April 11, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants