-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add renaming of ignore-git to changelog #110108
Merged
bors
merged 2 commits into
rust-lang:master
from
duckymirror:rename-ignore-git-changelog
Apr 10, 2023
Merged
Add renaming of ignore-git to changelog #110108
bors
merged 2 commits into
rust-lang:master
from
duckymirror:rename-ignore-git-changelog
Apr 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @ozkanonur (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Apr 9, 2023
onur-ozkan
approved these changes
Apr 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching this!
will queue it once the CI is green
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Apr 9, 2023
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 9, 2023
…gelog, r=ozkanonur Add renaming of ignore-git to changelog `bootstrap`'s `ignore-git` option has been renamed to `omit-git-hash` in rust-lang#110059. This PR adds this change to the `CHANGELOG.md`. See also rust-lang#110020 (comment).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#108843 (Instantiate instead of erasing binder when probing param methods) - rust-lang#109985 (Add little `is_test_crate` function) - rust-lang#110028 (Migrate `rustc_hir_analysis` to session diagnostic [Part 3]) - rust-lang#110095 (Migrate remainder of rustc_ty_utils to `SessionDiagnostic`) - rust-lang#110108 (Add renaming of ignore-git to changelog) - rust-lang#110114 (compiletest: Give a better error message if `node` isn't installed) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootstrap
'signore-git
option has been renamed toomit-git-hash
in #110059. This PR adds this change to theCHANGELOG.md
. See also #110020 (comment).