Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share slice of bytes #110145

Merged
merged 4 commits into from
May 17, 2023
Merged

Share slice of bytes #110145

merged 4 commits into from
May 17, 2023

Conversation

WaffleLapkin
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2023
@WaffleLapkin
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 10, 2023
@bors
Copy link
Contributor

bors commented Apr 10, 2023

⌛ Trying commit cb762279835a58b5d278672f7686eca9d1361e64 with merge 65c8042fdccd5d5ffaa31dee1c28c8c01b28e777...

Noratrieb
Noratrieb approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if perf is not sad, which it probably won't be

@noamtashma
Copy link
Contributor

Thanks!

A few questions/nits:

  • I wonder if this should be changed to SharedSlice now, but I guess it should really be called SharedOwnedSlice or LrcSlice, which imo just sound bad.
  • A few comments still refer to box.
  • Shouldn't the methods in MetadataLoader use MetadataBlob just so that the types would be a bit more clear?

@bors
Copy link
Contributor

bors commented Apr 10, 2023

☀️ Try build successful - checks-actions
Build commit: 65c8042fdccd5d5ffaa31dee1c28c8c01b28e777 (65c8042fdccd5d5ffaa31dee1c28c8c01b28e777)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (65c8042fdccd5d5ffaa31dee1c28c8c01b28e777): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.4% [0.4%, 0.4%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.6% [0.5%, 2.7%] 2
Regressions ❌
(secondary)		 2.5% [1.9%, 3.5%] 3
Improvements ✅
(primary)		 -2.3% [-2.3%, -2.3%] 1
Improvements ✅
(secondary)		 -4.0% [-7.2%, -1.2%] 3
All ❌✅ (primary) 0.3% [-2.3%, 2.7%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.1% [-0.5%, 0.4%] 2

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 10, 2023
@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2023
@rust-cloud-vms rust-cloud-vms bot force-pushed the share_slice_of_bytes branch from cb76227 to e39d61c Compare May 16, 2023 12:03
@WaffleLapkin
Copy link
Member Author

@noamtashma

I wonder if this should be changed to SharedSlice now, but I guess it should really be called SharedOwnedSlice or LrcSlice, which imo just sound bad.

Idk, maybe.

A few comments still refer to box.

Thanks for noticing, fixed.

Shouldn't the methods in MetadataLoader use MetadataBlob just so that the types would be a bit more clear?

That's not trivial since MetadataBlob is a pub(crate) struct in a different crate (I'm not even sure if they have a dependency edge between them...), this may be a good idea, but I don't want to work on it here. (I'd suggest you try it yourself after this PR is merged)

@WaffleLapkin
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 16, 2023
@Noratrieb
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 16, 2023

📌 Commit a6197a5 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 16, 2023
@Noratrieb
Copy link
Member

@bors rollup=maybe

@Dylan-DPC Dylan-DPC mentioned this pull request May 17, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2023
@bors
Auto merge of rust-lang#111671 - Dylan-DPC:rollup-1jy5r16, r=Dylan-DPC
c2ccc85 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#110145 (Share slice of bytes)
 - rust-lang#111043 (Stabilize feature `cstr_is_empty`)
 - rust-lang#111648 (Remove `LangItems::require`)
 - rust-lang#111649 (Add derive for `core::marker::ConstParamTy`)
 - rust-lang#111654 (Add a conversion from `&mut T` to `&mut UnsafeCell<T>`)
 - rust-lang#111661 (Erase regions of type in `offset_of!`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2a5c4ba into rust-lang:master May 17, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 17, 2023
@WaffleLapkin WaffleLapkin deleted the share_slice_of_bytes branch May 29, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
6 participants
@WaffleLapkin @rust-timer @bors @noamtashma @Noratrieb @rustbot