Rollup of 8 pull requests #110170
Merged
Rollup of 8 pull requests #110170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
…r=cuviper Set up standard library path substitution in rust-gdb and gdbgui Fixes rust-lang#62945 --- Only lightly tested (in release mode, where the paths are a bit of a mess) because my `gdb` appears to crash with `internal-error: inside_main_func: Assertion 'block != nullptr' failed.` and I don't have `gdbgui`. Please review carefully my shell syntax. There's also `rust-lldb`, but I don't know the equivalent for it.
…uto-trait-for-num-var, r=lcnr Stall auto trait assembly in new solver for int/float vars Make sure that we don't match int/float vars against *all* manual auto trait impls due to this check: https://github.com/rust-lang/rust/blob/2fb0e8d162a021f8a795fb603f5d8c0017855160/compiler/rustc_trait_selection/src/solve/trait_goals.rs#L151-L169 Since `find_map_relevant_impl` treats all impls as candidates for int/float vars, due to the way that `fast_reject::simplify_type` works. This fixes compiler-errors/next-solver-hir-issues#11. r? ``@lcnr``
Add support for RISC-V relax target feature This adds `relax` as an allowed RISC-V target feature. The relax feature in LLVM enables [linker relaxation](https://www.sifive.com/blog/all-aboard-part-3-linker-relaxation-in-riscv-toolchain), an optimization specific to RISC-V that allows global variable accesses to be resolved by the linker by using the global pointer (`gp`) register (rather than constructing the addresses from scratch for each access). Enabling `relax` will cause LLVM to emit relocations in the object file that support this. The feature can be enabled in rustc with `-C target-feature=+relax`. Currently this feature is disabled by default, but maybe it should be enabled by default since it is an easy performance improvement (but requires the `gp` register to be set up properly). GCC/Clang enable this feature by default (for both hosted/bare-metal targets), and include the `-mno-relax` flag to disable it (see [here](https://github.com/llvm/llvm-project/blob/466d554dcab39c3d42fe0c5b588b795e0e4b9d0d/clang/lib/Driver/ToolChains/Arch/RISCV.cpp#L145) for the code that enables it in Clang). I think it would make sense to enable by default, at least for all hosted targets since the `gp` register should be automatically set up by the runtime. For bare-metal targets, `gp` must be set up manually, so it is probably best to leave off by default to avoid breaking existing applications that do not set up `gp`. Leaving it disabled by default for all targets is also reasonable though. Let me know your thoughts. Thanks! Fixes rust-lang#109426.
…iser Update `error [E0449]: unnecessary visibility qualifier` to be more clear This updates the error message `error[E0449]: unnecessary visibility qualifier` by clearly indicating that visibility qualifiers already inherit their visibility from a parent item. The error message previously implied that the qualifiers were permitted, which is not the case anymore. Resolves rust-lang#109822.
The `wrapping_neg` example for unsigned types shouldn't use `i8` Probably it should have at least one example with an unsigned type.
fix(doc): do not parse inline when output is json for external crate relative rust-lang#110138
…-errors Add regression test for rust-lang#104916 Closes rust-lang#104916 I haven't tested if it still passes with debug assertions enabled so it'd be better to wait for CI to be green. r? compiler-errors
Update books ## rust-lang/book 1 commits in 0510ca84c2ce6bf93c4ccf9248756e9e4fd00b12..c06006157b14b3d47b5c716fc392b77f3b2e21ce 2023-04-03 15:31:55 UTC to 2023-04-03 15:31:55 UTC - Fix grammar (rust-lang/book#3600) ## rust-lang/reference 3 commits in 3c47807a3131b3c7cacb508f52632078d253cd0a..1f8dc727e94ae4ef92adf70df979521a1ea1143e 2023-04-09 14:04:53 UTC to 2023-03-29 13:21:47 UTC - Explain typos in `asm!` can be unsound (rust-lang/reference#1344) - Fix coding style in example: add space between module name and bracket (rust-lang/reference#1347) - redundant word removed (rust-lang/reference#1346) ## rust-lang/rust-by-example 1 commits in ba84bf35d0f17d404003349309201654d25f61af..31961fe22521a779070a44a8f30a2b00a20b6212 2023-04-10 13:06:34 UTC to 2023-04-10 13:06:34 UTC - Add clarity to name of file being used in library example. (rust-lang/rust-by-example#1697) ## rust-lang/rustc-dev-guide 8 commits in fca8af6c154c6cde2512f1331cf2704f214a818e..6337ed17fb8dcd918d78b7d97d213e923530337c 2023-04-10 14:23:05 UTC to 2023-04-06 00:29:18 UTC - fix markup (rust-lang/rustc-dev-guide#1670) - Reorganize "Getting Started" and add a "What should I work on?" section (rust-lang/rustc-dev-guide#1665) - Clarify cfg(bootstrap) docs (rust-lang/rustc-dev-guide#1669) - Link to forge instead of duplicating toolstate info (rust-lang/rustc-dev-guide#1664) - Improve the landing page for contributing to the libstd docs (rust-lang/rustc-dev-guide#1666) - Various improvements to `check_line_lengths.sh` (rust-lang/rustc-dev-guide#1667) - Document how to ignore specific files in a diff (rust-lang/rustc-dev-guide#1668) - mention `git clone --depth 1` (rust-lang/rustc-dev-guide#1663)
rustbot
added
S-waiting-on-review
|
@bors r+ p=8 rollup=never |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 48e14bb with merge 8b2a97dec4f931e92d2f6cf283b9fa7487a206a0... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
1 similar comment
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 5072826793 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
📌 Perf builds for each rolled up PR: previous master: b80ee3969f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (5072826): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
error [E0449]: unnecessary visibility qualifierto be more clear #109923 (Updateerror [E0449]: unnecessary visibility qualifierto be more clear)wrapping_negexample for unsigned types shouldn't usei8#110070 (Thewrapping_negexample for unsigned types shouldn't usei8)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup