-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explicit adt_dtorck_constraint
for ManuallyDrop
#110323
Conversation
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
Makes sense. r? @compiler-errors @bors r+ rollup |
⌛ Testing commit 64fbdc3 with merge 1d5bb85d2147a00a39023dd8215f6fc4888a4bca... |
💔 Test failed - checks-actions |
@bors retry spurious jobserver token error |
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Test successful - checks-actions |
1 similar comment
☀️ Test successful - checks-actions |
Finished benchmarking commit (ce1073b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. |
the only reason we didn't add outlives requirements when dropping
ManuallyDrop
was a fast-path intrivial_dropck_outlives
. Explicitly acknowledge that fast-path inadt_dtorck_constraint