Create try_new function for ThinBox #110483

tleibert · 2023-04-18T05:19:37Z

The allocator_api feature has proven very useful in my work in the FreeBSD kernel. I've found a few places where a ThinBox #92791 would be useful, but it must be able to be fallibly allocated for it to be used in the kernel.

This PR proposes a change to add such a constructor for ThinBox.

ACP: rust-lang/libs-team#213

rustbot · 2023-04-18T05:19:44Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot · 2023-04-18T05:19:47Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

tleibert · 2023-04-18T05:24:05Z

@rustbot label +T-libs-api -T-libs

clubby789 · 2023-04-18T23:14:51Z

Changes to unstable APIs require an API Change Proposal, linked in the bot comment

tleibert · 2023-04-19T00:28:46Z

API change proposal rust-lang/libs-team#213

thomcc · 2023-04-19T06:44:24Z

r=me on the impl, but needs api r+

thomcc · 2024-02-01T22:54:28Z

I'm going to be away for a few months, so I'm rerolling my PRs so that folks don't have to wait for me. Sorry/thanks.

r? libs

joshtriplett · 2024-02-11T02:55:33Z

Seems reasonable to me, and I'd approve it, except that there's an open ACP and I don't want to bypass that.

r? libs-api

dtolnay · 2024-02-11T18:59:22Z

library/alloc/src/boxed/thin.rs

+    /// #![feature(thin_box)]
+    /// use std::boxed::ThinBox;
+    ///
+    /// let five = ThinBox::new(5);


This example needs to cover ThinBox::try_new, not ThinBox::new.

dtolnay · 2024-02-11T19:27:02Z

library/alloc/src/boxed/thin.rs

 }

+#[unstable(feature = "thin_box", issue = "92791")]
+impl<T> ThinBox<T> {


Suggested change

}

#[unstable(feature = "thin_box", issue = "92791")]

impl<T> ThinBox<T> {

These impl blocks are identical. They should be combined into one block, otherwise rustdoc will render it as two different impl blocks.

dtolnay

Thank you!

dtolnay · 2024-02-11T19:29:50Z

@bors r+

bors · 2024-02-11T19:29:52Z

📌 Commit ea6944a has been approved by dtolnay

It is now in the queue for this repository.

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#110483 (Create try_new function for ThinBox) - rust-lang#120740 (Make cmath.rs a single file) - rust-lang#120872 (hir: Refactor getters for HIR parents) - rust-lang#120880 (add note on comparing vtables / function pointers) - rust-lang#120885 (interpret/visitor: ensure we only see normalized types) - rust-lang#120888 (assert_unsafe_precondition cleanup) - rust-lang#120897 (Encode `coroutine_for_closure` for foreign crates) - rust-lang#120937 ([docs] Update armv6k-nintendo-3ds platform docs for outdated info) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#110483 - tleibert:thin-box-try-new, r=dtolnay Create try_new function for ThinBox The `allocator_api` feature has proven very useful in my work in the FreeBSD kernel. I've found a few places where a `ThinBox` rust-lang#92791 would be useful, but it must be able to be fallibly allocated for it to be used in the kernel. This PR proposes a change to add such a constructor for ThinBox. ACP: rust-lang/libs-team#213

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#110483 (Create try_new function for ThinBox) - rust-lang#120740 (Make cmath.rs a single file) - rust-lang#120872 (hir: Refactor getters for HIR parents) - rust-lang#120880 (add note on comparing vtables / function pointers) - rust-lang#120885 (interpret/visitor: ensure we only see normalized types) - rust-lang#120888 (assert_unsafe_precondition cleanup) - rust-lang#120897 (Encode `coroutine_for_closure` for foreign crates) - rust-lang#120937 ([docs] Update armv6k-nintendo-3ds platform docs for outdated info) r? `@ghost` `@rustbot` modify labels: rollup

Create try_new function for ThinBox

3c880f2

rustbot assigned thomcc Apr 18, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 18, 2023

tleibert mentioned this pull request Apr 18, 2023

Tracking Issue for thin_box #92791

Open

4 tasks

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 18, 2023

thomcc added the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label May 5, 2023

Dylan-DPC removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2023

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Feb 1, 2024

rustbot assigned joshtriplett and unassigned thomcc Feb 1, 2024

rustbot assigned dtolnay and unassigned joshtriplett Feb 11, 2024

dtolnay requested changes Feb 11, 2024

View reviewed changes

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 11, 2024

Address ThinBox::try_new PR review

ea6944a

dtolnay approved these changes Feb 11, 2024

View reviewed changes

dtolnay removed T-libs Relevant to the library team, which will review and decide on the PR/issue. S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Feb 11, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2024

matthiaskrgr mentioned this pull request Feb 11, 2024

Rollup of 8 pull requests #120951

Merged

bors merged commit 251a09e into rust-lang:master Feb 12, 2024
11 checks passed

rustbot added this to the 1.78.0 milestone Feb 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create try_new function for ThinBox #110483

Create try_new function for ThinBox #110483

tleibert commented Apr 18, 2023 •

edited by Dylan-DPC

Loading

rustbot commented Apr 18, 2023

rustbot commented Apr 18, 2023

tleibert commented Apr 18, 2023

clubby789 commented Apr 18, 2023

tleibert commented Apr 19, 2023 •

edited

Loading

thomcc commented Apr 19, 2023

thomcc commented Feb 1, 2024

joshtriplett commented Feb 11, 2024

dtolnay Feb 11, 2024

dtolnay Feb 11, 2024

dtolnay left a comment

dtolnay commented Feb 11, 2024

bors commented Feb 11, 2024

Create try_new function for ThinBox #110483

Create try_new function for ThinBox #110483

Conversation

tleibert commented Apr 18, 2023 • edited by Dylan-DPC Loading

rustbot commented Apr 18, 2023

rustbot commented Apr 18, 2023

tleibert commented Apr 18, 2023

clubby789 commented Apr 18, 2023

tleibert commented Apr 19, 2023 • edited Loading

thomcc commented Apr 19, 2023

thomcc commented Feb 1, 2024

joshtriplett commented Feb 11, 2024

dtolnay Feb 11, 2024

Choose a reason for hiding this comment

dtolnay Feb 11, 2024

Choose a reason for hiding this comment

dtolnay left a comment

Choose a reason for hiding this comment

dtolnay commented Feb 11, 2024

bors commented Feb 11, 2024

tleibert commented Apr 18, 2023 •

edited by Dylan-DPC

Loading

tleibert commented Apr 19, 2023 •

edited

Loading