Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong comment in rustc_hir/src/hir.rs #110540

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Fix wrong comment in rustc_hir/src/hir.rs #110540

merged 1 commit into from
Apr 19, 2023

Conversation

safinaskar
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 19, 2023
@WaffleLapkin
Copy link
Member

r? @WaffleLapkin
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 19, 2023

📌 Commit 0b6b72e has been approved by WaffleLapkin

It is now in the queue for this repository.

@rustbot rustbot assigned WaffleLapkin and unassigned jackh726 Apr 19, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 19, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2023
@bors
Auto merge of rust-lang#110546 - matthiaskrgr:rollup-346kik6, r=matth…
9c51cf7 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#110123 ('./configure' now checks if 'config.toml' exists before writing to that destination)
 - rust-lang#110429 (Spelling src bootstrap)
 - rust-lang#110430 (Spelling src ci)
 - rust-lang#110515 (Don't special-case download-rustc in `maybe_install_llvm`)
 - rust-lang#110521 (Fix `x test lint-docs linkchecker` when download-rustc is enabled)
 - rust-lang#110525 (Fix `tests/run-make-translation` when download-rustc is enabled)
 - rust-lang#110531 (small type system cleanup)
 - rust-lang#110533 (Missing blanket impl trait not public)
 - rust-lang#110540 (Fix wrong comment in rustc_hir/src/hir.rs)
 - rust-lang#110541 (Fix various configure bugs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b59658c into rust-lang:master Apr 19, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 19, 2023
@safinaskar safinaskar deleted the patch-1 branch April 20, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@safinaskar @rustbot @WaffleLapkin @bors @jackh726