Add GenericArgKind::as_{type,const,region}
#110545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
generic_arg_as_x
branch
from
cd2c1fb to
3f15521
Compare
cjgillot
reviewed
Apr 19, 2023
| GenericArgKind::Const(ct) => Some(ct), | ||
| _ => None, | ||
| } | ||
| } |
There was a problem hiding this comment.
Should those methods be on GenericArgKind, or directly on GenericArg? Seems like we always unpack first.
There was a problem hiding this comment.
I implemented them on the kind because it technically supports more use cases, but given that we always unpack first, I can move it to the GenericArg...
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 20, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#110240 (Add `indent_style = tab` for `Makefile`s to `.editorconfig`) - rust-lang#110545 (Add `GenericArgKind::as_{type,const,region}`) - rust-lang#110574 ( fix out-of-date comment about rpath in bootstrap) - rust-lang#110581 (Style fix for loongarch-linux.md) - rust-lang#110584 (Allow overwriting the sysroot compile flag in compile tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to make code nicer in some cases