Skip to content

More mem::take in library #110633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2023
Merged

More mem::take in library #110633

merged 1 commit into from
Apr 21, 2023

Conversation

scottmcm
Copy link
Member

A bunch of places were using replace(…, &mut []), but that can just be take.

@scottmcm
More mem::take in library
8055bb8 
A bunch of places were using `replace(…, &mut [])`, but that can just be `take`.
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 21, 2023
@rustbot

This comment was marked as resolved.

Sign in to view
@thomcc
Copy link
Member

thomcc commented Apr 21, 2023

LGTM

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 21, 2023

📌 Commit 8055bb8 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2023
@Dylan-DPC Dylan-DPC mentioned this pull request Apr 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2023
@bors
Auto merge of rust-lang#110648 - Dylan-DPC:rollup-em3ovcq, r=Dylan-DPC
fec9adc 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#110333 (rustc_metadata: Split `children` into multiple tables)
 - rust-lang#110501 (rustdoc: fix ICE from rustc_resolve and librustdoc parse divergence)
 - rust-lang#110608 (Specialize some `io::Read` and `io::Write` methods for `VecDeque<u8>` and `&[u8]`)
 - rust-lang#110632 (Panic instead of truncating if the incremental on-disk cache is too big)
 - rust-lang#110633 (More `mem::take` in `library`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 482e407 into rust-lang:master Apr 21, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 21, 2023
@scottmcm scottmcm deleted the more-take branch April 21, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@scottmcm @rustbot @thomcc @bors