Add test for warning-free builds of core under no_global_oom_handling
#110652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
This was referenced Apr 21, 2023
dpaoliello
approved these changes
Apr 21, 2023
|
Could we do the equivalent of |
This comment has been minimized.
This comment has been minimized.
ojeda
force-pushed
the
core-no_global_oom_handling-test
branch
from
46b36fd
to
fccca0a
Compare
Good idea, but that is probably best as an independent PR (changing both tests). Why would we need |
This comment has been minimized.
This comment has been minimized.
ojeda
force-pushed
the
core-no_global_oom_handling-test
branch
from
fccca0a
to
592e8a4
Compare
…m_handling` `tests/run-make/alloc-no-oom-handling` tests that `alloc` under `no_global_oom_handling` builds and is warning-free. Do the same for `core` to prevent issues such as [1]. Link: rust-lang#110649 [1] Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
ojeda
force-pushed
the
core-no_global_oom_handling-test
branch
from
592e8a4
to
3938541
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
After #110649 lands this one can too. |
|
--emit=metadata is currently your best bet, we don't have a great alternative option today. Emitting the files itself should be pretty cheap I think, so I wouldn't worry too much about that. r=me with the needed commit landed to fix this (approved that, so should happen soon) |
|
Thanks Mark! I will send a PR to change the tests to |
47 tasks
|
@bors r+ rollup Sounds good. I think there is likely to not be much appetite for yet another emission kind, particularly if the gains are minimal (as I expect they will be). |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 30, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#110586 (Fix Unreadable non-UTF-8 output on localized MSVC) - rust-lang#110652 (Add test for warning-free builds of `core` under `no_global_oom_handling`) - rust-lang#110973 (improve error notes for packed struct reference diagnostic) - rust-lang#110981 (Move most rustdoc-ui tests into subdirectories) - rust-lang#110983 (rustdoc: Get `repr` information through `AdtDef` for foreign items) - rust-lang#110984 (Do not resolve anonymous lifetimes in consts to be static.) - rust-lang#110997 (Improve internal field comments on `slice::Iter(Mut)`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/run-make/alloc-no-oom-handlingtests thatallocunderno_global_oom_handlingbuilds and is warning-free.Do the same for
coreto prevent issues such as [1].Link: #110649 [1]