Generalize item_span into node_span, which works on more types. #11066
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
|
Interesting! This patch itself seems useful in some contexts, but I would want to see it used somewhere in the compiler before committing it. I agree that the failure messages aren't quite up to par with what they should be, and this should likely have the For now though, the bors queue is quite long, and I want to try to keep it a little smaller than we have been. I would be totally fine accepting this in a the patch which uses this method, but until that time I don't think it's worth it to have a separate pull request for it. I'm very curious to see how much this helps other portions of the compiler! |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 16, 2023
close rust-lang#11066 close rust-lang#11665 close rust-lang#11911
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 16, 2023
…-null, r=llogiq
fix(ptr_as_ptr): handle `std::ptr::null{_mut}`
close rust-lang#11066
close rust-lang#11665
close rust-lang#11911
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: [`ptr_as_ptr`]: handle `std::ptr::null` and `std::ptr::null_mut`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually suspect the function shouldn't be written in this particular way, so I'd like some commentary. (This function is not used by anything yet, but I'm working on better error messages so it will come in handy for another patch)
Signed-off-by: Edward Z. Yang ezyang@cs.stanford.edu