Skip to content

Print ty placeholders pretty #110660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2023
Merged

Print ty placeholders pretty #110660

merged 1 commit into from
Apr 22, 2023

Conversation

compiler-errors
Copy link
Member

Makes anon placeholders print like !0 instead of Placeholder { ... }.

rustc_trait_selection::solve::compute_well_formed_goal goal=Goal{
    predicate: !0,
    param_env: ParamEnv{
      caller_bounds: [
        Binder(TraitPredicate(<!0 as std::marker::Copy>, polarity: Positive), []),
        Binder(TraitPredicate(<!0 as std::clone::Clone>, polarity: Positive), []),
        Binder(TraitPredicate(<!0 as std::marker::Sized>, polarity: Positive), []),
      ],
      reveal: UserFacing,
      constness: NotConst,
    }
  }

cc @BoxyUwU who might care about this formatting decision

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2023
@rust-cloud-vms rust-cloud-vms bot force-pushed the placeholders-pretty branch 2 times, most recently from 1dc1511 to 5063c1f Compare April 22, 2023 00:05
wesleywiser
wesleywiser approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if @BoxyUwU does not have concerns

@BoxyUwU
Copy link
Member

BoxyUwU commented Apr 22, 2023

@bors r=wesleywiser,BoxyUwU rollup

@bors
Copy link
Collaborator

bors commented Apr 22, 2023

📌 Commit 5063c1fd146e88c32400f63f4f01b53a1574205f has been approved by wesleywiser,BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2023
@BoxyUwU
Copy link
Member

BoxyUwU commented Apr 22, 2023

@bors r- xd

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 22, 2023
BoxyUwU
BoxyUwU reviewed Apr 22, 2023
View reviewed changes
@rust-cloud-vms rust-cloud-vms bot force-pushed the placeholders-pretty branch from 5063c1f to 1d7a247 Compare April 22, 2023 01:25
@BoxyUwU
Copy link
Member

BoxyUwU commented Apr 22, 2023

@bors r=wesleywiser,BoxyUwU

@bors
Copy link
Collaborator

bors commented Apr 22, 2023

📌 Commit 1d7a247 has been approved by wesleywiser,BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 22, 2023
@JohnTitor JohnTitor mentioned this pull request Apr 22, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2023
@bors
Auto merge of rust-lang#110666 - JohnTitor:rollup-3pwilte, r=JohnTitor
3128fd8 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#109949 (rustdoc: migrate `document_type_layout` to askama)
 - rust-lang#110622 (Stable hash tag (discriminant) of `GenericArg`)
 - rust-lang#110635 (More `IS_ZST` in `library`)
 - rust-lang#110640 (compiler/rustc_target: Raise m68k-linux-gnu baseline to 68020)
 - rust-lang#110657 (nit: consistent naming for SimplifyConstCondition)
 - rust-lang#110659 (rustdoc: clean up JS)
 - rust-lang#110660 (Print ty placeholders pretty)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 16e2096 into rust-lang:master Apr 22, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 22, 2023
@compiler-errors compiler-errors deleted the placeholders-pretty branch August 11, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxyUwU BoxyUwU BoxyUwU left review comments

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @BoxyUwU @bors @wesleywiser