Implement FusedIterator for DecodeUtf16 when the inner iterator does #110729

ColinFinck · 2023-04-23T16:38:20Z

I have just implemented an iterator that wraps DecodeUtf16 and wanted to implement FusedIterator for my iterator when I noticed that DecodeUtf16 currently doesn't implement FusedIterator at all.
A quick look at the code of DecodeUtf16 revealed that DecodeUtf16::next only returns None when its inner iterator returns None:

rust/library/core/src/char/decode.rs

Line 45 in 3462f79

None => self.iter.next()?,

As a result, we can implement FusedIterator for DecodeUtf16 when the inner iterator does.

I'm following the example of #96397 here and consider this change minor and non-controversial, which is why I haven't added an RFC. I have also added the required feature name ("decode_utf16_fused_iterator"), however without adding a chapter to the Rust Unstable book (same as #96397).

rustbot · 2023-04-23T16:38:27Z

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-04-23T16:38:30Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

workingjubilee · 2023-07-31T22:39:20Z

r? libs-api

Needs FCP for a "passthrough" impl of impl<T> FusedIterator for DecodeUtf16<T> where T: FusedIterator. Seems unobjectionable.

dtolnay · 2023-09-28T07:17:22Z

@rust-lang/libs-api:
@rfcbot fcp merge

rfcbot · 2023-09-28T07:17:25Z

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2023-10-05T14:47:54Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2023-10-15T14:51:15Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

dtolnay

Thanks!

dtolnay · 2023-10-15T16:30:09Z

@bors r+

bors · 2023-10-15T16:30:12Z

📌 Commit 60fd119 has been approved by dtolnay

It is now in the queue for this repository.

bors · 2023-10-15T17:09:41Z

⌛ Testing commit 60fd119 with merge 64368d0...

bors · 2023-10-15T19:01:42Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 64368d0 to master...

rust-timer · 2023-10-16T01:12:47Z

Finished benchmarking commit (64368d0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.7%, -2.6%]	3
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 624.98s -> 625.359s (0.06%)
Artifact size: 305.53 MiB -> 305.52 MiB (-0.00%)

Pkgsrc changes: * Adjust patches and cargo checksums to new versions. * For an external LLVM, set dependency of llvm >= 16, in accordance with the upstream changes. * Mark that on NetBSD we now need >= 9.0, so 8.x is no longer supported. * On NetBSD/sparc64 10.x, we now need GCC 12 to build the embedded LLVM, which is version 17; apparently GCC 10.4 or 10.5 mis-compiles it, resulting in an illegal instruction fault during the build. Ref. rust-lang/rust#117231 Upstream changes: Version 1.75.0 (2023-12-28) ========================== - [Stabilize `async fn` and return-position `impl Trait` in traits.] (rust-lang/rust#115822) - [Allow function pointer signatures containing `&mut T` in `const` contexts.] (rust-lang/rust#116015) - [Match `usize`/`isize` exhaustively with half-open ranges.] (rust-lang/rust#116692) - [Guarantee that `char` has the same size and alignment as `u32`.] (rust-lang/rust#116894) - [Document that the null pointer has the 0 address.] (rust-lang/rust#116988) - [Allow partially moved values in `match`.] (rust-lang/rust#103208) - [Add notes about non-compliant FP behavior on 32bit x86 targets.] (rust-lang/rust#113053) - [Stabilize ratified RISC-V target features.] (rust-lang/rust#116485) Compiler -------- - [Rework negative coherence to properly consider impls that only partly overlap.] (rust-lang/rust#112875) - [Bump `COINDUCTIVE_OVERLAP_IN_COHERENCE` to deny, and warn in dependencies.] (rust-lang/rust#116493) - [Consider alias bounds when computing liveness in NLL.] (rust-lang/rust#116733) - [Add the V (vector) extension to the `riscv64-linux-android` target spec.] (rust-lang/rust#116618) - [Automatically enable cross-crate inlining for small functions] (rust-lang/rust#116505) - Add several new tier 3 targets: - [`csky-unknown-linux-gnuabiv2hf`] (rust-lang/rust#117049) - [`i586-unknown-netbsd`] (rust-lang/rust#117170) - [`mipsel-unknown-netbsd`] (rust-lang/rust#117356) Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Override `Waker::clone_from` to avoid cloning `Waker`s unnecessarily.] (rust-lang/rust#96979) - [Implement `BufRead` for `VecDeque<u8>`.] (rust-lang/rust#110604) - [Implement `FusedIterator` for `DecodeUtf16` when the inner iterator does.] (rust-lang/rust#110729) - [Implement `Not, Bit{And,Or}{,Assign}` for IP addresses.] (rust-lang/rust#113747) - [Implement `Default` for `ExitCode`.] (rust-lang/rust#114589) - [Guarantee representation of None in NPO] (rust-lang/rust#115333) - [Document when atomic loads are guaranteed read-only.] (rust-lang/rust#115577) - [Broaden the consequences of recursive TLS initialization.] (rust-lang/rust#116172) - [Windows: Support sub-millisecond sleep.] (rust-lang/rust#116461) - [Fix generic bound of `str::SplitInclusive`'s `DoubleEndedIterator` impl] (rust-lang/rust#100806) - [Fix exit status / wait status on non-Unix `cfg(unix)` platforms.] (rust-lang/rust#115108) Stabilized APIs --------------- - [`Atomic*::from_ptr`] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicUsize.html#method.from_ptr) - [`FileTimes`] (https://doc.rust-lang.org/stable/std/fs/struct.FileTimes.html) - [`FileTimesExt`] (https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTimesExt.html) - [`File::set_modified`] (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.set_modified) - [`File::set_times`] (https://doc.rust-lang.org/stable/std/fs/struct.File.html#method.set_times) - [`IpAddr::to_canonical`] (https://doc.rust-lang.org/stable/core/net/enum.IpAddr.html#method.to_canonical) - [`Ipv6Addr::to_canonical`] (https://doc.rust-lang.org/stable/core/net/struct.Ipv6Addr.html#method.to_canonical) - [`Option::as_slice`] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.as_slice) - [`Option::as_mut_slice`] (https://doc.rust-lang.org/stable/core/option/enum.Option.html#method.as_mut_slice) - [`pointer::byte_add`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_add) - [`pointer::byte_offset`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_offset) - [`pointer::byte_offset_from`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_offset_from) - [`pointer::byte_sub`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.byte_sub) - [`pointer::wrapping_byte_add`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.wrapping_byte_add) - [`pointer::wrapping_byte_offset`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.wrapping_byte_offset) - [`pointer::wrapping_byte_sub`] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.wrapping_byte_sub) These APIs are now stable in const contexts: - [`Ipv6Addr::to_ipv4_mapped`] (https://doc.rust-lang.org/stable/core/net/struct.Ipv6Addr.html#method.to_ipv4_mapped) - [`MaybeUninit::assume_init_read`] (https://doc.rust-lang.org/stable/core/mem/union.MaybeUninit.html#method.assume_init_read) - [`MaybeUninit::zeroed`] (https://doc.rust-lang.org/stable/core/mem/union.MaybeUninit.html#method.zeroed) - [`mem::discriminant`] (https://doc.rust-lang.org/stable/core/mem/fn.discriminant.html) - [`mem::zeroed`] (https://doc.rust-lang.org/stable/core/mem/fn.zeroed.html) Cargo ----- - [Add new packages to `[workspace.members]` automatically.] (rust-lang/cargo#12779) - [Allow version-less `Cargo.toml` manifests.] (rust-lang/cargo#12786) - [Make browser links out of HTML file paths.] (rust-lang/cargo#12889) Rustdoc ------- - [Accept less invalid Rust in rustdoc.] (rust-lang/rust#117450) - [Document lack of object safety on affected traits.] (rust-lang/rust#113241) - [Hide `#[repr(transparent)]` if it isn't part of the public ABI.] (rust-lang/rust#115439) - [Show enum discriminant if it is a C-like variant.] (rust-lang/rust#116142) Compatibility Notes ------------------- - [FreeBSD targets now require at least version 12.] (rust-lang/rust#114521) - [Formally demote tier 2 MIPS targets to tier 3.] (rust-lang/rust#115238) - [Make misalignment a hard error in `const` contexts.] (rust-lang/rust#115524) - [Fix detecting references to packed unsized fields.] (rust-lang/rust#115583) - [Remove support for compiler plugins.] (rust-lang/rust#116412)

rustbot assigned joshtriplett Apr 23, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 23, 2023

This comment has been minimized.

Sign in to view

Implement FusedIterator for DecodeUtf16 when the inner iterator does

60fd119

ColinFinck force-pushed the decode-utf16-fused-iterator branch from 73b6c36 to 60fd119 Compare April 24, 2023 11:34

cuviper added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 24, 2023

workingjubilee added the needs-fcp This change is insta-stable, so needs a completed FCP to proceed. label Jul 31, 2023

rustbot assigned m-ou-se and unassigned joshtriplett Jul 31, 2023

dtolnay assigned dtolnay and unassigned m-ou-se Sep 28, 2023

dtolnay approved these changes Sep 28, 2023

View reviewed changes

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 28, 2023

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 5, 2023

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 15, 2023

rfcbot added the to-announce Announce this issue on triage meeting label Oct 15, 2023

dtolnay approved these changes Oct 15, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 15, 2023

bors merged commit 64368d0 into rust-lang:master Oct 15, 2023
1 check passed

rustbot added this to the 1.75.0 milestone Oct 15, 2023

Veykril mentioned this pull request Oct 17, 2023

Pull upstream master 2023 10 17 ferrocene/ferrocene#54

Merged

apiraino removed the to-announce Announce this issue on triage meeting label Oct 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement FusedIterator for DecodeUtf16 when the inner iterator does #110729

Implement FusedIterator for DecodeUtf16 when the inner iterator does #110729

ColinFinck commented Apr 23, 2023 •

edited by workingjubilee

Loading

rustbot commented Apr 23, 2023

rustbot commented Apr 23, 2023

This comment has been minimized.

This comment has been minimized.

workingjubilee commented Jul 31, 2023

dtolnay commented Sep 28, 2023

rfcbot commented Sep 28, 2023 •

edited by BurntSushi

Loading

rfcbot commented Oct 5, 2023

rfcbot commented Oct 15, 2023

dtolnay left a comment

dtolnay commented Oct 15, 2023

bors commented Oct 15, 2023

bors commented Oct 15, 2023

bors commented Oct 15, 2023

rust-timer commented Oct 16, 2023

Implement FusedIterator for DecodeUtf16 when the inner iterator does #110729

Implement FusedIterator for DecodeUtf16 when the inner iterator does #110729

Conversation

ColinFinck commented Apr 23, 2023 • edited by workingjubilee Loading

rustbot commented Apr 23, 2023

rustbot commented Apr 23, 2023

This comment has been minimized.

This comment has been minimized.

workingjubilee commented Jul 31, 2023

dtolnay commented Sep 28, 2023

rfcbot commented Sep 28, 2023 • edited by BurntSushi Loading

rfcbot commented Oct 5, 2023

rfcbot commented Oct 15, 2023

dtolnay left a comment

Choose a reason for hiding this comment

dtolnay commented Oct 15, 2023

bors commented Oct 15, 2023

bors commented Oct 15, 2023

bors commented Oct 15, 2023

rust-timer commented Oct 16, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

ColinFinck commented Apr 23, 2023 •

edited by workingjubilee

Loading

rfcbot commented Sep 28, 2023 •

edited by BurntSushi

Loading