Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size asserts for MIR SourceScopeData & VarDebugInfo #110750

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

scottmcm
Copy link
Member

There's vectors of both of these in mir::Body, so might as well track them.

(I was pondering adding something to one or the other, so wanted this to see the memory impact.)

There's vectors of both of these in `mir::Body`, so might as well track them.
@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 24, 2023
@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit 31531ce has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2023
Rollup of 10 pull requests

Successful merges:

 - rust-lang#110480 (Add `known-bug` tests for 11 unsound issues)
 - rust-lang#110539 (Move around `{Idx, IndexVec, IndexSlice}` adjacent code)
 - rust-lang#110590 (Add some tests around (lack of) object safety of associated types and consts)
 - rust-lang#110602 (Ignore src/bootstrap formatting commit in .git-blame-ignore-revs)
 - rust-lang#110667 (pointer-auth-link-with-c: Fix cross compilation.)
 - rust-lang#110681 (drop few unused crates, gate libc under unix for rustc_codegen_ssa)
 - rust-lang#110685 (Some cleanups to DataflowConstProp)
 - rust-lang#110744 (bootstrap: update paths cargo-credential crate)
 - rust-lang#110750 (Add size asserts for MIR `SourceScopeData` & `VarDebugInfo`)
 - rust-lang#110760 (rustdoc: Add regression test for rust-lang#60522)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 16fdef7 into rust-lang:master Apr 24, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 24, 2023
@scottmcm scottmcm deleted the vardebug-size branch April 24, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants