Get comm_adapters building again #11081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I accidentally removed this module from compilation awhile back, this adds it back in. Closes rust-lang#11076
bors
added a commit
that referenced
this pull request
Dec 20, 2013
I accidentally removed this module from compilation awhile back, this adds it back in. Closes #11076
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2023
[`useless_vec`]: use the source span for initializer Fixes rust-lang#11075. changelog: [`useless_vec`]: use the source span for the initializer expression when inside of a macro
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2023
[`useless_vec`]: add more tests and don't lint inside of macros Closes rust-lang#11084. I realized that the fix I added in rust-lang#11081 itself also causes an error in a suggestion when inside of a macro. Example: ```rs macro_rules! x { () => { for _ in vec![1, 2] {} } } x!(); ``` Here it would suggest replacing `vec![1, 2]` with `[x!()]`, because that's what the source callsite is (reminder: it does this to get the correct span of `x!()` for code like `for _ in vec![x!()]`), but that's wrong when *inside* macros, so I decided to make it not lint if the whole loop construct is inside a macro to avoid this issue. changelog: [`useless_vec`]: add more tests and don't lint inside of macros r? `@Alexendoo` since these were your tests, I figured it makes most sense to assign you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally removed this module from compilation awhile back, this adds it
back in.
Closes #11076