Skip to content

Optimize dataflow-const-prop place-tracking infra #110820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 11, 2023
+183 −141
Merged

Optimize dataflow-const-prop place-tracking infra #110820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
71138e9
Make HasTop and HasBottom consts.
cjgillot Apr 24, 2023
7c3d551
Create tracked places breadth first.
cjgillot Apr 22, 2023
38fa676
Precompute values to flood.
cjgillot Apr 23, 2023
2b0bf3c
Trim the places that will not be used.
cjgillot Apr 24, 2023
add5124
Extract handle_set_discriminant.
cjgillot Apr 25, 2023
79c0737
Do not flood on copy_nonoverlapping.
cjgillot Apr 25, 2023
2aa1c23
Add a few comments.
cjgillot May 8, 2023
ccc1da2
Prevent stack overflow.
cjgillot May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions compiler/rustc_mir_dataflow/src/framework/lattice.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,12 @@ pub trait MeetSemiLattice: Eq {

/// A set that has a "bottom" element, which is less than or equal to any other element.
pub trait HasBottom {
fn bottom() -> Self;
const BOTTOM: Self;
}

/// A set that has a "top" element, which is greater than or equal to any other element.
pub trait HasTop {
fn top() -> Self;
const TOP: Self;
}

/// A `bool` is a "two-point" lattice with `true` as the top element and `false` as the bottom:
Expand Down Expand Up @@ -113,15 +113,11 @@ impl MeetSemiLattice for bool {
}

impl HasBottom for bool {
fn bottom() -> Self {
false
}
const BOTTOM: Self = false;
}

impl HasTop for bool {
fn top() -> Self {
true
}
const TOP: Self = true;
}

/// A tuple (or list) of lattices is itself a lattice whose least upper bound is the concatenation
Expand Down Expand Up @@ -274,13 +270,9 @@ impl<T: Clone + Eq> MeetSemiLattice for FlatSet<T> {
}

impl<T> HasBottom for FlatSet<T> {
fn bottom() -> Self {
Self::Bottom
}
const BOTTOM: Self = Self::Bottom;
}

impl<T> HasTop for FlatSet<T> {
fn top() -> Self {
Self::Top
}
const TOP: Self = Self::Top;
}
Loading