Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiletest: emit assembly-output header in error #110851

Merged
merged 1 commit into from
Apr 27, 2023
Merged

compiletest: emit assembly-output header in error #110851

merged 1 commit into from
Apr 27, 2023

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Apr 26, 2023

Improve the error message.

@rustbot
Copy link
Collaborator

rustbot commented Apr 26, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 26, 2023
@compiler-errors
Copy link
Member

I tested this, and yeah this is better.

r? @compiler-errors @bors r+ rollup

In the future, it may be useful to show what the difference in output looks like for the reviewer, though.

@bors
Copy link
Collaborator

bors commented Apr 27, 2023

📌 Commit 9b2cf89 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned oli-obk Apr 27, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 27, 2023
@matthiaskrgr
Rollup merge of rust-lang#110851 - tamird:better-error-compiletest, r…
781ae27 
…=compiler-errors

compiletest: emit assembly-output header in error

Improve the error message.
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 27, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2023
@bors
Auto merge of rust-lang#110916 - matthiaskrgr:rollup-g3c33zc, r=matth…
1a6ae3d 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#105745 (docs(std): clarify remove_dir_all errors)
 - rust-lang#106456 (Correct `std::prelude` comment)
 - rust-lang#106599 (Change memory ordering in System wrapper example)
 - rust-lang#110838 (More `Typefoldable`/`TypeVisitable` cleanups)
 - rust-lang#110851 (compiletest: emit assembly-output header in error)
 - rust-lang#110853 (compiletest: add bpf-linker assembly support)
 - rust-lang#110878 (Add `known-bug` tests for 4 unsound issues)
 - rust-lang#110886 (`DepGraph` cleanups)
 - rust-lang#110905 (Remove invalid value from scraped-examples.md)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 743d565 into rust-lang:master Apr 27, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 27, 2023
@tamird tamird deleted the better-error-compiletest branch April 28, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tamird @rustbot @compiler-errors @bors @oli-obk