Nicer ICE for #67981 #110872
Merged
Nicer ICE for #67981 #110872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
wesleywiser
approved these changes
Apr 27, 2023
|
Thanks @Jules-Bertholet! @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 27, 2023
…ywiser Nicer ICE for rust-lang#67981 Provides a slightly nicer ICE for rust-lang#67981, documenting the problem. A proper fix will be necessary before `#![feature(unsized_fn_params)]` can be stabilized. The problem is that the design of the `"rust-call"` ABI is fundamentally not compatible with `unsized_fn_params`. `"rust-call"` functions need to collect their arguments into a tuple, but if the arguments are not `Sized`, said tuple is potentially not even a valid type—and if it is, it requires `alloca` to create. `@rustbot` label +A-abi +A-codegen +F-unboxed_closures +F-unsized_fn_params
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#110426 (docs(style): add more let-else examples) - rust-lang#110804 (Remove repeated definite articles) - rust-lang#110814 (Sprinkle some `#[inline]` in `rustc_data_structures::tagged_ptr`) - rust-lang#110816 (Migrate `rustc_passes` to translatable diagnostics) - rust-lang#110864 (`IntoFuture::into_future` is no longer unstable) - rust-lang#110866 (Make `method-not-found-generic-arg-elision.rs` error message not path dependent) - rust-lang#110872 (Nicer ICE for rust-lang#67981) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a slightly nicer ICE for #67981, documenting the problem. A proper fix will be necessary before
#![feature(unsized_fn_params)]can be stabilized.The problem is that the design of the
"rust-call"ABI is fundamentally not compatible withunsized_fn_params."rust-call"functions need to collect their arguments into a tuple, but if the arguments are notSized, said tuple is potentially not even a valid type—and if it is, it requiresallocato create.@rustbot label +A-abi +A-codegen +F-unboxed_closures +F-unsized_fn_params