Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: Strip struct fields and enum variants #11093

Merged
merged 1 commit into from
Jan 3, 2014
Merged

rustc: Strip struct fields and enum variants #11093

merged 1 commit into from
Jan 3, 2014

Conversation

alexcrichton
Copy link
Member

Closes #11085

@huonw
Copy link
Member

huonw commented Dec 21, 2013

You'll need xfail-fast because of the compile-flags.

@alexcrichton
Copy link
Member Author

xfail-fast added, nice catch

@huonw
Copy link
Member

huonw commented Dec 22, 2013

Hm, what about

enum Foo {
    Bar {
        #[cfg(foo)] a: int, 
        b: int
    }
}

@alexcrichton
Copy link
Member Author

Fields in struct variants are now handled.

bors added a commit that referenced this pull request Jan 3, 2014
@bors
auto merge of #11093 : alexcrichton/rust/issue-11085, r=pcwalton
fb46225 
Closes #11085
@bors bors closed this Jan 3, 2014
@bors bors merged commit 1c648fc into rust-lang:master Jan 3, 2014
@alexcrichton alexcrichton deleted the issue-11085 branch January 3, 2014 18:26
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 14, 2023
@bors
Auto merge of rust-lang#11098 - y21:issue11093, r=giraffate
3b43b1e 
[`unnecessary_literal_unwrap`]: also lint `unwrap_(err_)unchecked`

Closes rust-lang#11093

changelog: [`unnecessary_literal_unwrap`]: also lint `unwrap_unchecked` and `unwrap_err_unchecked`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[cfg] does not filter struct fields or enum variants
4 participants
@alexcrichton @huonw @pcwalton @bors