Fix the test directories suggested by ./x.py suggest
#111002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests that were in `src/test/` have been moved to `tests/`, so the paths given by the suggestion tool should reflect this.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
|
I think we should consider autogenerating these paths from the |
|
@bors r+ rollup In the meantime, this seems like a good change. |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 6, 2023
…mulacrum Fix the test directories suggested by `./x.py suggest` It seems that these paths were correct when rust-lang#106249 was being written, but since then rust-lang#106458 has been merged (moving `src/test/` to `tests/`), making the tool's suggestions incorrect.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 6, 2023
…mulacrum Fix the test directories suggested by `./x.py suggest` It seems that these paths were correct when rust-lang#106249 was being written, but since then rust-lang#106458 has been merged (moving `src/test/` to `tests/`), making the tool's suggestions incorrect.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111002 (Fix the test directories suggested by `./x.py suggest`) - rust-lang#111077 (Make more ConstProp tests unit.) - rust-lang#111151 (check bootstrap scripts syntax) - rust-lang#111203 (Output LLVM optimization remark kind in `-Cremark` output) - rust-lang#111237 (asm: loongarch64: Implementation of clobber_abi) - rust-lang#111274 (Expand the LLVM coverage of `--print target-cpus`) - rust-lang#111289 (Check arguments length in trivial diagnostic lint) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that these paths were correct when #106249 was being written, but since then #106458 has been merged (moving
src/test/totests/), making the tool's suggestions incorrect.