Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.70.0 release notes #111006

Merged
merged 1 commit into from
May 27, 2023
Merged

1.70.0 release notes #111006

merged 1 commit into from
May 27, 2023

Conversation

Mark-Simulacrum
Copy link
Member

r? @cuviper @rust-lang/release

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Apr 30, 2023
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
@saethlin
Copy link
Member

saethlin commented May 5, 2023

#98112 got the relnotes label but I can't find it in the diff (I've never interacted with this process before).

@Mark-Simulacrum
Copy link
Member Author

I think I dropped it because I assumed (incorrectly?) that it wouldn't apply to user usage, perhaps because our tooling got sorted under T-libs.

@saethlin
Copy link
Member

saethlin commented May 6, 2023

Race condition. This will be much more clear once you get to the crater triage :)

@Mark-Simulacrum
Copy link
Member Author

Updated with stabilized APIs and fixing nits, going to go ahead and approve since release is next week.

@bors r+ rollup p=1

@bors
Copy link
Contributor

bors commented May 27, 2023

📌 Commit 89b9b25 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2023
@bors
Copy link
Contributor

bors commented May 27, 2023

⌛ Testing commit 89b9b25 with merge bc428f8...

@bors
Copy link
Contributor

bors commented May 27, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing bc428f8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 27, 2023
@bors bors merged commit bc428f8 into rust-lang:master May 27, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 27, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bc428f8): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.2%, 0.3%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.05s -> 647.298s (0.19%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.