Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove allow(rustc::potential_query_instability) for builtin_macros #111027

Merged
merged 2 commits into from
May 4, 2023
Merged

Remove allow(rustc::potential_query_instability) for builtin_macros #111027

merged 2 commits into from
May 4, 2023

Conversation

clubby789
Copy link
Contributor

cc #84447

@rustbot
Copy link
Collaborator

rustbot commented Apr 30, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 30, 2023
@clubby789 clubby789 changed the title Remove allow(rustc::potential_query_instability) for builin_macros Remove allow(rustc::potential_query_instability) for builtin_macros Apr 30, 2023
@clubby789 clubby789 force-pushed the query-instability-builtin-macros branch from ebd174c to 4262a6b Compare April 30, 2023 19:56
@bors

This comment was marked as resolved.

Sign in to view
@clubby789 clubby789 force-pushed the query-instability-builtin-macros branch from 4262a6b to 1590350 Compare May 2, 2023 15:34
@rustbot
Copy link
Collaborator

rustbot commented May 2, 2023

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 3, 2023

📌 Commit e3e93f2 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request May 4, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2023
@bors
Auto merge of rust-lang#111174 - matthiaskrgr:rollup-ncnqivh, r=matth…
eac3558 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#110859 (Explicitly reject negative and reservation drop impls)
 - rust-lang#111020 (Validate resolution for SelfCtor too.)
 - rust-lang#111024 (Use the full Fingerprint when stringifying Svh)
 - rust-lang#111027 (Remove `allow(rustc::potential_query_instability)` for `builtin_macros`)
 - rust-lang#111039 (Encode def span for foreign return-position `impl Trait` in trait)
 - rust-lang#111070 (Don't suffix `RibKind` variants)
 - rust-lang#111094 (Add needs-unwind annotations to tests that need stack unwinding)
 - rust-lang#111103 (correctly recurse when expanding anon consts)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6387eda into rust-lang:master May 4, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
5 participants
@clubby789 @rustbot @bors @petrochenkov @compiler-errors