diagnostics: exclude indirect private deps from trait impl suggest #111076

notriddle · 2023-05-01T19:16:51Z

rustbot · 2023-05-01T19:17:00Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

compiler/rustc_metadata/src/creader.rs

b-naber

The approach seems better than the previous one, but I'm not sure I fully understand what you're doing here since I don't really know the code in rustc_metadata.

b-naber · 2023-05-07T20:02:25Z

compiler/rustc_metadata/src/rmeta/decoder.rs

@@ -111,7 +111,7 @@ pub(crate) struct CrateMetadata {
    source: Lrc<CrateSource>,
    /// Whether or not this crate should be consider a private dependency
    /// for purposes of the 'exported_private_dependencies' lint
-    private_dep: bool,
+    private_dep: Lock<bool>,


AtomicBool should suffice here.

Could you update the comment?

b-naber · 2023-05-07T20:05:41Z

r? rust-lang/compiler

src/bootstrap/metadata.rs

src/tools/rust-installer/combine-installers.sh

src/tools/rust-installer/gen-installer.sh

src/tools/rust-installer/make-tarballs.sh

src/tools/tidy/src/main.rs

cjgillot · 2023-05-07T21:47:01Z

compiler/rustc_metadata/src/rmeta/decoder.rs

@@ -111,7 +111,7 @@ pub(crate) struct CrateMetadata {
    source: Lrc<CrateSource>,
    /// Whether or not this crate should be consider a private dependency
    /// for purposes of the 'exported_private_dependencies' lint
-    private_dep: bool,
+    private_dep: Lock<bool>,


Could you update the comment?

compiler/rustc_metadata/src/creader.rs

cjgillot · 2023-05-07T21:59:15Z

compiler/rustc_middle/src/ty/util.rs

+        // | Yes     | No     | No      | !(true && !false)  |
+        // | No      | No     | Yes     | !(false && !false) |
+        !(self.is_private_dep(key)
+            && !self.extern_crate(key.as_def_id()).expect("crate must exist").is_direct())


This is not what None means. See the doc on extern_crate field in rustc_metadata::rmeta::decoder::CrateMetadata.

library/std/tests/common/mod.rs

bors · 2023-05-08T15:20:24Z

☔ The latest upstream changes (presumably #111346) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_metadata/src/rmeta/decoder.rs

rust-timer · 2023-05-31T18:14:22Z

Finished benchmarking commit (ad8304a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	14
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 643.343s -> 642.658s (-0.11%)

danakj · 2023-06-02T15:19:12Z

Hey, it looks like this PR breaks building the toolchain with the Cargo binaries specified in https://github.com/rust-lang/rust/blob/master/src/stage0.json#L28-L83

The public-dependencies feature is a nightly feature, but the Cargo given there is beta.

linux_upload_rust log:
 Downloading https://chrome-infra-packages.appspot.com/dl/infra/3pp/static_libs/openssl/linux-amd64/+/version:2@1.1.1j.chromium.2 .......... Done.
 Downloading https://static.rust-lang.org/dist/2023-05-30/cargo-beta-x86_64-unknown-linux-gnu.tar.gz .......... Done.
 Running git submodule update --init --recursive --depth 1
 Running /b/s/w/ir/cache/builder/src/third_party/llvm-build-tools/cargo-beta-x86_64-unknown-linux-gnu/cargo/bin/cargo vendor --locked --versioned-dirs --sync ./src/tools/cargo/Cargo.toml --sync ./src/tools/rust-analyzer/Cargo.toml --sync ./compiler/rustc_codegen_cranelift/Cargo.toml --sync ./src/bootstrap/Cargo.toml
 error: failed to load manifest for workspace member `/b/s/w/ir/cache/builder/src/third_party/rust_src/src/library/std`
 
 Caused by:
   failed to parse manifest at `/b/s/w/ir/cache/builder/src/third_party/rust_src/src/library/std/Cargo.toml`
 
 Caused by:
   the cargo feature `public-dependency` requires a nightly version of Cargo, but this is the `beta` channel
   See https://doc.rust-lang.org/book/appendix-07-nightly-rust.html for more information about Rust release channels.
   See https://doc.rust-lang.org/beta/cargo/reference/unstable.html#public-dependency for more information about using this feature.
 Failed.

How do we continue building the toolchain in this state?

Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1450894

danakj · 2023-06-02T15:34:33Z

Maybe answering for myself but it looks like specifying RUSTC_BOOTSTRAP=1 in the environment is required now. Is this something that will stay and cover any other nightly stuff going forward?

bjorn3 · 2023-06-12T13:58:15Z

I'm not sure RUSTC_BOOTSTRAP should be suggested. The cargo version used to vendor may not support public-dependency or it may have an incompatible implementation. By the way I opened #112391 a couple of days ago as I didn't notice this discussion.

Since rust-lang#111076 enables unstable cargo feature (`public-dependency`), we need to ensure that unstable features are enabled before reading libstd Cargo.toml. Signed-off-by: onur-ozkan <work@onurozkan.dev>

enable unstable feature on `x clean [PATH]` Since rust-lang#111076 enables unstable cargo feature (`public-dependency`), we need to ensure that unstable features are enabled before reading libstd Cargo.toml. Fixes rust-lang#117762 cc `@Nilstrieb`

In [1], most dependencies of `std` and other sysroot crates were marked private, but this did not happen for `alloc` and `test`. Update these here, marking public standard library crates as the only non-private dependencies. [1]: rust-lang#111076

In [1], most dependencies of `std` and other sysroot crates were marked private, but this did not happen for `alloc` and `test`. Update these here, marking public standard library crates as the only non-private dependencies. [1]: rust-lang/rust#111076

In [1], most dependencies of `std` and other sysroot crates were marked private, but this did not happen for `alloc` and `test`. Update these here, marking public standard library crates as the only non-private dependencies. [1]: rust-lang#111076

rustbot assigned b-naber May 1, 2023

notriddle marked this pull request as draft May 1, 2023 19:17

This comment has been minimized.

Sign in to view

notriddle force-pushed the notriddle/silence-private-dep-trait-impl-suggestions branch from 8453818 to 8bf782f Compare May 1, 2023 19:33

This comment has been minimized.

Sign in to view

notriddle force-pushed the notriddle/silence-private-dep-trait-impl-suggestions branch 2 times, most recently from e96a4b5 to 60ed017 Compare May 1, 2023 20:18

notriddle marked this pull request as ready for review May 1, 2023 20:18

cjgillot reviewed May 1, 2023

View reviewed changes

compiler/rustc_metadata/src/creader.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

notriddle force-pushed the notriddle/silence-private-dep-trait-impl-suggestions branch 2 times, most recently from 06f0be5 to 2bffa4c Compare May 1, 2023 22:41

b-naber reviewed May 7, 2023

View reviewed changes

rustbot assigned oli-obk and unassigned b-naber May 7, 2023

cjgillot reviewed May 7, 2023

View reviewed changes

notriddle force-pushed the notriddle/silence-private-dep-trait-impl-suggestions branch from 8482f07 to 394d31c Compare May 8, 2023 21:31

This comment has been minimized.

Sign in to view

notriddle force-pushed the notriddle/silence-private-dep-trait-impl-suggestions branch from 97264e2 to fcee118 Compare May 8, 2023 21:57

klensy reviewed May 8, 2023

View reviewed changes

compiler/rustc_metadata/src/rmeta/decoder.rs Show resolved Hide resolved

notriddle assigned cjgillot May 8, 2023

rustbot added this to the 1.72.0 milestone May 31, 2023

notriddle deleted the notriddle/silence-private-dep-trait-impl-suggestions branch May 31, 2023 16:56

bjorn3 mentioned this pull request Jun 7, 2023

Vendoring broken with stable rustc #112391

Closed

klensy mentioned this pull request Jul 9, 2023

the trait bound &[u8]: std::convert::From<&[_; 0]> is not satisfied #113238

Closed

onur-ozkan mentioned this pull request Nov 9, 2023

enable unstable feature on x clean [PATH] #117765

Merged

bjorn3 mentioned this pull request Jan 14, 2025

Exclude dependencies of std for diagnostics #135278

Merged

m-ou-se mentioned this pull request Feb 11, 2025

Add *_value methods to proc_macro lib #136355

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

diagnostics: exclude indirect private deps from trait impl suggest #111076

diagnostics: exclude indirect private deps from trait impl suggest #111076

notriddle commented May 1, 2023 •

edited

Loading

rustbot commented May 1, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

b-naber left a comment

b-naber May 7, 2023

cjgillot May 7, 2023

b-naber commented May 7, 2023

cjgillot May 7, 2023

cjgillot May 7, 2023

bors commented May 8, 2023

This comment has been minimized.

rust-timer commented May 31, 2023

danakj commented Jun 2, 2023 •

edited

Loading

danakj commented Jun 2, 2023

bjorn3 commented Jun 12, 2023 •

edited

Loading

diagnostics: exclude indirect private deps from trait impl suggest #111076

diagnostics: exclude indirect private deps from trait impl suggest #111076

Conversation

notriddle commented May 1, 2023 • edited Loading

rustbot commented May 1, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

b-naber left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

b-naber commented May 7, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bors commented May 8, 2023

This comment has been minimized.

rust-timer commented May 31, 2023

Overall result: no relevant changes - no action needed

danakj commented Jun 2, 2023 • edited Loading

danakj commented Jun 2, 2023

bjorn3 commented Jun 12, 2023 • edited Loading

notriddle commented May 1, 2023 •

edited

Loading

danakj commented Jun 2, 2023 •

edited

Loading

bjorn3 commented Jun 12, 2023 •

edited

Loading