added TraitAlias to check_item() for missing_docs #111150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/cargo cc @ehuss |
|
sry, fixing the cargo commit |
|
This needs a test case, added to |
petrochenkov
reviewed
May 5, 2023
petrochenkov
added
S-waiting-on-author
mj10021
force-pushed
the
issue-111025-fix
branch
2 times, most recently
from
7381adf
to
8bd819d
Compare
|
Does that look right then? @rustbot review |
rustbot
added
S-waiting-on-review
petrochenkov
reviewed
May 6, 2023
petrochenkov
added
S-waiting-on-author
petrochenkov
reviewed
May 6, 2023
|
The Could you also squash commits into one after addressing all the comments? |
mj10021
force-pushed
the
issue-111025-fix
branch
2 times, most recently
from
9555efc
to
7373c1f
Compare
add test and bless
|
@bors r+ |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#105583 (Operand::extract_field: only cast llval if it's a pointer and replace bitcast w/ pointercast.) - rust-lang#110094 (clean up `transmute`s in `core`) - rust-lang#111150 (added TraitAlias to check_item() for missing_docs) - rust-lang#111293 (rustc --explain E0726 - grammar fixing (it's => its + add a `the` where it felt right to do so)) - rust-lang#111300 (Emit while_true lint spanning the entire loop condition) - rust-lang#111301 (Remove calls to `mem::forget` and `mem::replace` in `Option::get_or_insert_with`.) - rust-lang#111303 (update Rust Unstable Book docs for `--extern force`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Issue #111025 should now be closed, right?. It wasn't auto-closed as the PR description didn't contain a trigger like Fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in issue #111025 the
missing_docswas not being triggered for trait aliases. I addedTraitAliasto the pattern match for check_item(), and the lint seems to be behaving appropriately