-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pulldown-cmark
to 0.9.3
#111152
update pulldown-cmark
to 0.9.3
#111152
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
9740c4c
to
b451c0c
Compare
pulldown-cmark
+ add regression test for double backtick broken link rustdoc ICEpulldown-cmark
to 0.9.3
b451c0c
to
8a5eb55
Compare
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
r? rustdoc @rustbot ready |
The strikethrough change might be worth documenting in @rustbot label relnotes I'm not sure if this counts as a new feature or is just a bug fix, since we already document that rustdoc supports GFM strikethrough. /// ~~old~~ ~new~
pub fn strike() {} |
8a5eb55
to
073e19f
Compare
r? @GuillaumeGomez maybe? |
Thanks for the update and the new test! Can you also update this section of the rustdoc book please? You can edit it in |
Also merge the two almost identical strikethrough tests together and document what the test tests.
073e19f
to
c2a446a
Compare
I've added a comment to the test and updated the rustdoc book. I also verified that the single tilde striketrough actually renders correctly in the book. |
Thanks! @bors r+ rollup |
…rd, r=GuillaumeGomez update `pulldown-cmark` to `0.9.3` This PR updates `pulldown-cmark` to version `0.9.3`, which does two main things: * Pulls in pulldown-cmark/pulldown-cmark#643 to fix rust-lang#111117 * Allows parsing strikethrough with single tildes, e.g. `~foo~` -> ~foo~. This matches the [GFM spec](https://github.github.com/gfm/#strikethrough-extension-). Full changelog: pulldown-cmark/pulldown-cmark#646
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#107522 (Add Median of Medians fallback to introselect) - rust-lang#111152 (update `pulldown-cmark` to `0.9.3`) - rust-lang#111757 (Consider lint check attributes on match arms) - rust-lang#111831 (Always capture slice when pattern requires checking the length) - rust-lang#111929 (Don't print newlines in APITs) - rust-lang#111945 (Migrate GUI colors test to original CSS color format) - rust-lang#111950 (Remove ExpnKind::Inlined.) r? `@ghost` `@rustbot` modify labels: rollup
This PR updates
pulldown-cmark
to version0.9.3
, which does two main things:~foo~
->foo. This matches the GFM spec.Full changelog: pulldown-cmark/pulldown-cmark#646