Add a lint for lets/matches which won't do anything #11122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly do anything (irrefutable, no bindings). Will be useful once the semantics of _ in patterns changes to "ignore" instead of "drop" (rust-lang#10488). Closes rust-lang#11088.
|
(Changing the deriving code to not generate a "useless" match will be annoying and not an improvement (no particular need for that special case), so the best way to handle that will be putting an |
|
(Yeah I figured it would be something like that. Thanks.) |
|
(Gah, apparently "Close" doesn't mean the comment box.) |
|
Closing due to inactivity. This probably needs to get rebased around #11585, but I'm not sure how they interact with one another. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2023
…lip1995 Pass correct substs to `implements_trait` in `incorrect_impls` `Copy<T>` does in fact not exist. The substs on the trait_ref contain the `Self` type of the impl as the first parameter, so passing that to `implements_trait`, which then nicely prepends the `Self` type for us does not end will. fixes rust-lang#11121 The assertions requires debug assertions inside rustc, which is probably why it didn't fire here. I tested the change locally in rust-lang/rust and it did not ICE anymore. cc `@xFrednet` `@Centri3` changelog: [`incorrect_impls`]: fix confusion about generic parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in other words irrefutable ones without any bindings. This will be useful once the semantics of
_in patterns changes to "ignore" instead of "drop" (#10488). Closes #11088.For now it defaults to "allow", so I don't think there's any harm in this going in before #10488 itself, but please DON'T r+ this unless you're in a position to decide (or it has been decided).
If I run the tests with it set to "deny", things break in all of the expected places, with the exception that
derivingcode for unit structs also appears to trigger it. That should presumably be fixed before it gets changed to something other than "allow" (along with of course the expected failures).