Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rustc-build-sysroot to fix miri sysroot build #111236

Merged
merged 1 commit into from
May 5, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 5, 2023

@rustbot
Copy link
Collaborator

rustbot commented May 5, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 5, 2023

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@RalfJung
Copy link
Member Author

RalfJung commented May 5, 2023

This only affects Miri so I will take the liberty to self-approve. Also this should land ASAP to unbreak Miri in the next nightly.

@bors r+ p=5

@bors
Copy link
Contributor

bors commented May 5, 2023

📌 Commit cdd67ed has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2023
@bors
Copy link
Contributor

bors commented May 5, 2023

⌛ Testing commit cdd67ed with merge dd9a7bf...

@bors
Copy link
Contributor

bors commented May 5, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing dd9a7bf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 5, 2023
@bors bors merged commit dd9a7bf into rust-lang:master May 5, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 5, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dd9a7bf): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.2% [1.6%, 3.1%] 4
Regressions ❌
(secondary)
3.1% [2.5%, 3.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [1.6%, 3.1%] 4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 654.604s -> 654.413s (-0.03%)

@RalfJung RalfJung deleted the miri-sysroot branch May 11, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proc_macro crate missing from miri sysroot beginning nightly-2023-05-05
5 participants