Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #111402

Merged
merged 14 commits into from
May 9, 2023
Merged

Rollup of 6 pull requests #111402

merged 14 commits into from
May 9, 2023

Commits on May 5, 2023

  1. Configuration menu
    Copy the full SHA
    23e443a View commit details
    Browse the repository at this point in the history
  2. Stabilize const_ptr_read

    bors authored and usbalbin committed May 5, 2023
    Configuration menu
    Copy the full SHA
    81c2459 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    442617c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    73b3ce2 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Configuration menu
    Copy the full SHA
    ec3a9bc View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Configuration menu
    Copy the full SHA
    bb4976a View commit details
    Browse the repository at this point in the history
  2. Move tests

    c410-f3r committed May 8, 2023
    Configuration menu
    Copy the full SHA
    0285611 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    d5843dd View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#97320 - usbalbin:stabilize_const_ptr_read, …

    …r=m-ou-se
    
    Stabilize const_ptr_read
    
    Stabilizes const_ptr_read, with tracking issue rust-lang#80377
    matthiaskrgr committed May 9, 2023
    Configuration menu
    Copy the full SHA
    88fbfaf View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#110770 - m-ou-se:fmt-temp-lifetime, r=oli-obk

    Limit lifetime of format_args!() with inlined args.
    
    Fixes rust-lang#110769
    matthiaskrgr committed May 9, 2023
    Configuration menu
    Copy the full SHA
    e4c8250 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#111021 - c410-f3r:dqewdas, r=petrochenkov

    Move some tests
    
    r? ``@petrochenkov``
    matthiaskrgr committed May 9, 2023
    Configuration menu
    Copy the full SHA
    985ea22 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#111215 - BoxyUwU:resolve_anon_consts_differ…

    …ently, r=cjgillot
    
    Various changes to name resolution of anon consts
    
    Sorry this PR is kind of all over the place ^^'
    
    Fixes rust-lang#111012
    
    - Rewrites anon const nameres to all go through `fn resolve_anon_const` explicitly instead of `visit_anon_const` to ensure that we do not accidentally resolve anon consts as if they are allowed to use generics when they aren't. Also means that we dont have bits of code for resolving anon consts that will get out of sync (i.e. legacy const generics and resolving path consts that were parsed as type arguments)
    - Renames two of the `LifetimeRibKind`, `AnonConst -> ConcreteAnonConst` and `ConstGeneric -> ConstParamTy`
    - Noticed while doing this that under `generic_const_exprs` all lifetimes currently get resolved to errors without any error being emitted which was causing a bunch of tests to pass without their bugs having been fixed, incidentally fixed that in this PR and marked those tests as `// known-bug:`. I'm fine to break those since `generic_const_exprs` is a very unstable incomplete feature and this PR _does_ make generic_const_exprs "less broken" as a whole, also I can't be assed to figure out what the underlying causes of all of them are. This PR reopens rust-lang#77357 rust-lang#83993
    - Changed `generics_of` to stop providing generics and predicates to enum variant discriminant anon consts since those are not allowed to use generic parameters
    - Updated the error for non 'static lifetime in const arguments and the error for non 'static lifetime in const param tys to use `derive(Diagnostic)`
    
    I have a vague idea why const-arg-in-const-arg.rs, in-closure.rs and simple.rs have started failing which is unfortunate since these were deliberately made to work, I think lifetime resolution being broken just means this regressed at some point and nobody noticed because the tests were not testing anything :( I'm fine breaking these too for the same reason as the tests for rust-lang#77357 rust-lang#83993. I couldn't get `// known-bug` to work for these ICEs and just kept getting different stderr between CI and local `--bless` so I just removed them and will create an issue to track re-adding (and fixing) the bugs if this PR lands.
    
    r? `@cjgillot` cc `@compiler-errors`
    matthiaskrgr committed May 9, 2023
    Configuration menu
    Copy the full SHA
    363d158 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#111242 - wangkirin:support_rpath_independen…

    …t_config, r=albertlarsan68
    
    support set `rpath` option  for each target independently
    
    Currently  the `rpath` option is a global config and it's effect on all targets.
    But sometimes when developers edit the rustc code and try to release rust toolchains themselves, they may not want to add `rpath` in all targets  to avoid dynamically linked shared object library privilege escalation attack.
    This PR supports set `rpath` option  for each target independently .
    Common developers are not aware of the existence of this configuration  option and do not affect the existing development process. This configuration option takes effect only after developers explicitly sets .
    
    r? ``@albertlarsan68``
    matthiaskrgr committed May 9, 2023
    Configuration menu
    Copy the full SHA
    efe697e View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#111282 - scottmcm:remove-unneeded-assumes, …

    …r=workingjubilee
    
    Remove some `assume`s from slice iterators that don't do anything
    
    Because the start pointer is iterators is already a `NonNull`, we emit the appropriate `!nonnull` metadata when loading the pointer to tell LLVM that it's non-null.
    
    Probably the best way to see that it's the metadata that's important (and not the `assume`) is to observe that LLVM actually *removes* the `assume` from the optimized IR: <https://rust.godbolt.org/z/KhE6G963n>.
    
    (I also checked that, yes, the if-not-ZST `assume` on `end` is still doing something: it's how there's a `!nonnull` metadata on its load, even though it's an ordinary raw pointer.  The codegen test added in this PR fails if the other `assume` is  removed.)
    matthiaskrgr committed May 9, 2023
    Configuration menu
    Copy the full SHA
    273fbf4 View commit details
    Browse the repository at this point in the history