Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(resolve): clean up the early error return caused by non-call #111428

Merged
merged 1 commit into from
May 16, 2023
Merged

refactor(resolve): clean up the early error return caused by non-call #111428

merged 1 commit into from
May 16, 2023

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented May 10, 2023 •
edited by Dylan-DPC
Loading

closes #109250

It seems no bad happened, r? @Nilstrieb

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 10, 2023
@Noratrieb
Copy link
Member

This was added in #72923 with no justification or explanation. It was probably added just because the example contained it?
Thanks for fixing it.
@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 16, 2023

📌 Commit 7c1bc03 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2023
This was referenced May 16, 2023
Closed
Merged
Noratrieb added a commit to Noratrieb/rust that referenced this pull request May 16, 2023
@Noratrieb
Rollup merge of rust-lang#111428 - bvanjoi:fix-109250, r=Nilstrieb
a776f90 
refactor(resolve): clean up the early error return caused by non-call

closes rust-lang#109250

It seems no bad happened, r? `@Nilstrieb`
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2023
@bors
Auto merge of rust-lang#111639 - Nilstrieb:rollup-vg149lm, r=Nilstrieb
a673ad6 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#111428 (refactor(resolve): clean up the early error return caused by non-call)
 - rust-lang#111449 (Recover `impl<T ?Sized>` correctly)
 - rust-lang#111572 (Document that `missing_copy_implementations` and `missing_debug_implementations` only apply to public items.)
 - rust-lang#111602 (Suppress "erroneous constant used" for constants tainted by errors)
 - rust-lang#111605 (fixup version placeholder for `cfi_encoding` feature)
 - rust-lang#111607 (Add clubby789 to the bootstrap review rotation)
 - rust-lang#111614 (Add more interesting nonsense to weird-exprs.rs)
 - rust-lang#111617 (Fixed typo)
 - rust-lang#111620 (Add eholk back to compiler-contributors reviewers)
 - rust-lang#111621 (Fix release date of 1.58.1 in release notes.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f652815 into rust-lang:master May 16, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 16, 2023
@bvanjoi bvanjoi deleted the fix-109250 branch May 20, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

Don't bail out on non-calls in resolver diagnostics
4 participants
@bvanjoi @Noratrieb @bors @rustbot